[GitHub] [hbase] saintstack commented on a change in pull request #754: HBASE-22978 : Online slow response log

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r369308592
 
 

 ##########
 File path: hbase-shell/src/main/ruby/shell/commands/get_slowlog_responses.rb
 ##########
 @@ -0,0 +1,65 @@
+#
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with this
+# work for additional information regarding copyright ownership. The ASF
+# licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+# Retrieve latest slowlog responses maintained in memory by RegionServers
+
+module Shell
+  module Commands
+    # Retrieve latest slowlog responses
+    class GetSlowlogResponses < Command
+      def help
+        <<-EOF
+Retrieve latest SlowLog Responses maintained by each or specific RegionServers.
+Specify 'all_rs' to include all RS otherwise array of 'server_name' for specific
+RS. 'server_name' is the host, port plus startcode of a RegionServer.
+e.g.: host187.example.com,60020,1289493121758 (find servername in
+master ui or when you do detailed status in shell)
+
+Provide optional filter parameters as Hash
+
+Examples:
+
+  hbase> get_slowlog_responses 'all_rs'                            => get slowlog responses from all RS
+  hbase> get_slowlog_responses ['server_name1', 'server_name2']    => get slowlog responses from server_name1,
+                                                                      server_name2
+  hbase> get_slowlog_responses 'all_rs', {'REGION_NAME' => 'hbase:meta,,1'}
+                                                                   => get slowlog responses only related to meta
+                                                                      region
+  hbase> get_slowlog_responses 'all_rs', {'TABLE_NAME' => 't1'}    => get slowlog responses only related to t1 table
+  hbase> get_slowlog_responses 'all_rs', {'CLIENT_IP' => '192.162.1.40:60225'}
+                                                                   => get slowlog responses with given client
+                                                                      IP address
+  hbase> get_slowlog_responses 'all_rs', {'REGION_NAME' => 'hbase:meta,,1', 'TABLE_NAME' => 't1'}
+                                                                   => get slowlog responses with given region name
+                                                                      or table name
+  hbase> get_slowlog_responses 'all_rs', {'USER' => 'user_name', 'CLIENT_IP' => '192.162.1.40:60225'}
+                                                                   => get slowlog responses that match either
+                                                                      provided client IP address or user name
+
+        EOF
+      end
+
+      def command(server_names, args = {})
+        unless args.is_a? Hash
+          raise 'Filter parameters are not Hash'
+        end
+
+        admin.get_slowlog_responses(server_names, args)
+      end
+    end
+  end
+end
 
 Review comment:
   Good

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services