You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jeffkbkim (via GitHub)" <gi...@apache.org> on 2023/04/18 12:44:45 UTC

[GitHub] [kafka] jeffkbkim opened a new pull request, #13596: KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…

jeffkbkim opened a new pull request, #13596:
URL: https://github.com/apache/kafka/pull/13596

   …art-1) (#13511)
   
   This patch implemented the first part of KIP-915. It updates the group coordinator and the transaction coordinator to ignores unknown record types while loading their respective state from the partitions. This allows downgrades from future versions that will include new record types.
   
   Reviewers: Alexandre Dupriez <al...@gmail.com>, David Jacot <dj...@confluent.io>
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] dajac merged pull request #13596: KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #13596:
URL: https://github.com/apache/kafka/pull/13596


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] dajac commented on pull request #13596: KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #13596:
URL: https://github.com/apache/kafka/pull/13596#issuecomment-1515975989

   @jeffkbkim This PR has failures related to the change. Could you take a look?
   ```
   Build / JDK 11 and Scala 2.13 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
   <1s
   Build / JDK 11 and Scala 2.13 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
   <1s
   Build / JDK 16 and Scala 2.13 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
   <1s
   Build / JDK 16 and Scala 2.13 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
   <1s
   Build / JDK 8 and Scala 2.12 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
   <1s
   Build / JDK 8 and Scala 2.12 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org