You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by "Fang Zheng (JIRA)" <ji...@apache.org> on 2018/10/30 22:35:00 UTC

[jira] [Created] (ORC-428) Use ORC_UNIQUE_PTR consistently in OrcFile, OrcHdfsFile, and Writer

Fang Zheng created ORC-428:
------------------------------

             Summary: Use ORC_UNIQUE_PTR consistently in OrcFile, OrcHdfsFile, and Writer
                 Key: ORC-428
                 URL: https://issues.apache.org/jira/browse/ORC-428
             Project: ORC
          Issue Type: Bug
          Components: C++
            Reporter: Fang Zheng


In OrcFile.hh, the declarations of  readLocalFile() and other four functions return  ORC_UNIQUE_PTR:

ORC_UNIQUE_PTR<InputStream> readLocalFile(const std::string& path);

ORC_UNIQUE_PTR<InputStream> readHdfsFile(const std::string& path);

ORC_UNIQUE_PTR<Reader> createReader(ORC_UNIQUE_PTR<InputStream> stream,
 const ReaderOptions& options);

ORC_UNIQUE_PTR<Writer> createWriter(const Type& type, OutputStream* stream, const WriterOptions& options);

However, these functions' definitions all return std::unique_ptr. On a system where ORC_UNIQUE_PTR is not defined as std::unique_ptr but std::auto_ptr, there is inconsistency.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)