[jira] Commented: (JAMES-709) [PATCH] Log IO issues to help diagnosis

["Joachim Draeger (JIRA)" <se...@james.apache.org>]

    [ http://issues.apache.org/jira/browse/JAMES-709?page=comments#action_12451575 ] 
            
Joachim Draeger commented on JAMES-709:
---------------------------------------


1. I agree that every Exception caught somewhere should be logged at least to debug.

2. Logging issues twice could be confusing. We should try to log exceptions when caught, not when thrown. If the Exceptions are finally logged with stacktrace, we should simply use nested Exceptions.

3. If we want to log something to info/warn/error, we should try to smartly extend the Exception hierarchy and try to log them where they are finally handled.

IMO http://svn.apache.org/viewvc?view=rev&revision=477572 brings the same information. 

I plan to go systematically through the IMAP code to make sure Exceptions are properly logged. There are 63 matches of the word "catch". It should be possible to do a quick review.



> [PATCH] Log IO issues to help diagnosis
> ---------------------------------------
>
>                 Key: JAMES-709
>                 URL: http://issues.apache.org/jira/browse/JAMES-709
>             Project: James
>          Issue Type: Improvement
>          Components: IMAPServer
>    Affects Versions: Trunk
>            Reporter: Robert Burrell Donkin
>         Attachments: james-imap-io-diagnostics.patch
>
>
> Log IO issues to help diagnostics

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org