You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "HardX8 (via GitHub)" <gi...@apache.org> on 2024/08/08 09:36:24 UTC
[PR] Add test [rocketmq]
HardX8 opened a new pull request, #8508:
URL: https://github.com/apache/rocketmq/pull/8508
### Motivation
Fixes #8262
### Summary
Add test for:
1. org.apache.rocketmq.acl.common.AuthorizationHeader
2. org.apache.rocketmq.acl.plain.PlainPermissionChecker
### CheckList
测试用例已经全部通过
### This modification is assisted by the Tongyi Lingcode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8519] Add test [rocketmq]
Posted by "HardX8 (via GitHub)" <gi...@apache.org>.
HardX8 commented on PR #8508:
URL: https://github.com/apache/rocketmq/pull/8508#issuecomment-2282644001
> Hi @HardX8 , it's better to create a new issue for this PR.
Thank you for reminding me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8519] Add test case for rocketmq acl module. [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8508:
URL: https://github.com/apache/rocketmq/pull/8508#issuecomment-2291027297
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8508?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 46.93%. Comparing base [(`d3d7b28`)](https://app.codecov.io/gh/apache/rocketmq/commit/d3d7b280a1a5d9d2f69af0aa74affe71c9232513?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`eb10447`)](https://app.codecov.io/gh/apache/rocketmq/commit/eb1044798078e0be7dce9d7e50893b2fc6eae4af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 3 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8508 +/- ##
=============================================
- Coverage 46.98% 46.93% -0.05%
+ Complexity 11327 11325 -2
=============================================
Files 1275 1275
Lines 89067 89067
Branches 11456 11456
=============================================
- Hits 41844 41803 -41
- Misses 42043 42084 +41
Partials 5180 5180
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8508?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8519] Add test case for rocketmq acl module. [rocketmq]
Posted by "HardX8 (via GitHub)" <gi...@apache.org>.
HardX8 commented on PR #8508:
URL: https://github.com/apache/rocketmq/pull/8508#issuecomment-2292878685
All checks have passed,could you please merge this PR so that I can submit my results? @ShannonDing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8519] Add test case for rocketmq acl module. [rocketmq]
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing commented on PR #8508:
URL: https://github.com/apache/rocketmq/pull/8508#issuecomment-2283002501
link #8262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test [rocketmq]
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on PR #8508:
URL: https://github.com/apache/rocketmq/pull/8508#issuecomment-2282636637
Hi @HardX8 , it's better to create a new issue for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8519] Add test case for rocketmq acl module. [rocketmq]
Posted by "HardX8 (via GitHub)" <gi...@apache.org>.
HardX8 commented on PR #8508:
URL: https://github.com/apache/rocketmq/pull/8508#issuecomment-2291219486
Could you please let me know what additional changes I need to make to this PR in order for it to be approved for merging? @ShannonDing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8519] Add test case for rocketmq acl module. [rocketmq]
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing merged PR #8508:
URL: https://github.com/apache/rocketmq/pull/8508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8519] Add test case for rocketmq acl module. [rocketmq]
Posted by "HardX8 (via GitHub)" <gi...@apache.org>.
HardX8 commented on PR #8508:
URL: https://github.com/apache/rocketmq/pull/8508#issuecomment-2283032657
> lack of license header.
I have finished adding the license header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org