[GitHub] [samza] rmatharu commented on a change in pull request #1531: SAMZA-2688: [Elasticity] introduce configs and sub-partition concept aka SystemStreamPartitionKeyHash

[GitBox <gi...@apache.org>]

rmatharu commented on a change in pull request #1531:
URL: https://github.com/apache/samza/pull/1531#discussion_r711290092



##########
File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java
##########
@@ -71,6 +74,7 @@ public IncomingMessageEnvelope(SystemStreamPartition systemStreamPartition, Stri
     this.message = message;
     this.size = size;
     this.arrivalTime = Instant.now().toEpochMilli();
+    this.hashCodeForKeyHashComputation = key != null ? key.hashCode() : offset != null ? offset.hashCode() : hashCode();

Review comment:
       Is there a benefit to caching and storing it, rather than computing and exposing it via a function?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org