You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "tsreaper (via GitHub)" <gi...@apache.org> on 2023/03/21 02:57:01 UTC

[GitHub] [incubator-paimon] tsreaper opened a new pull request, #671: [FLINK-31433] Make SchemaChange serializable

tsreaper opened a new pull request, #671:
URL: https://github.com/apache/incubator-paimon/pull/671

   ### Purpose
   
   To avoid concurrent changes to table schema, CDC sinks for Paimon should send all `SchemaChange` to a special process function. This process function only has 1 parallelism and it is dedicated for schema changes.
   
   To pass `SchemaChange` through network, `SchemaChange` must be serializable.
   
   ### Tests
   
   N/A
   
   ### API and Format 
   
   N/A
   
   ### Documentation
   
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #671: [FLINK-31433] Make SchemaChange serializable

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #671:
URL: https://github.com/apache/incubator-paimon/pull/671#discussion_r1142851930


##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaChange.java:
##########
@@ -306,6 +325,9 @@ public int hashCode() {
 
     /** A SchemaChange to update the field position. */
     final class UpdateColumnPosition implements SchemaChange {
+
+        private static final long serialVersionUID = 1L;
+
         private final Move move;

Review Comment:
   `Move` is not serializable.
   You can add test for all class instances.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] tsreaper merged pull request #671: [FLINK-31433] Make SchemaChange serializable

Posted by "tsreaper (via GitHub)" <gi...@apache.org>.
tsreaper merged PR #671:
URL: https://github.com/apache/incubator-paimon/pull/671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org