You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/04/18 02:19:59 UTC
[GitHub] [hadoop] GuoPhilipse commented on a diff in pull request #4160: HDFS-16537.Fix oev decode xml error
GuoPhilipse commented on code in PR #4160:
URL: https://github.com/apache/hadoop/pull/4160#discussion_r851841569
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java:
##########
@@ -2946,7 +2946,7 @@ void fromXml(Stanza st) throws InvalidXmlException {
this.newLength = Long.parseLong(st.getValue("NEWLENGTH"));
this.timestamp = Long.parseLong(st.getValue("TIMESTAMP"));
if (st.hasChildren("BLOCK"))
- this.truncateBlock = FSEditLogOp.blockFromXml(st);
+ this.truncateBlock = FSEditLogOp.blockFromXml(st.getChildren("BLOCK").get(0));
Review Comment:
thanks @Hexiaoqiao for your review, will add test later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org