[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3569: ARTEMIS-3285 potential duplicate messages with LVQ + non-destructive

[GitBox <gi...@apache.org>]

jbertram commented on a change in pull request #3569:
URL: https://github.com/apache/activemq-artemis/pull/3569#discussion_r629596410



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSNonDestructiveTest.java
##########
@@ -588,4 +594,82 @@ private void sendLVQTombstone(ConnectionSupplier producerConnectionSupplier, Str
          producer.send(message1, javax.jms.Message.DEFAULT_DELIVERY_MODE, javax.jms.Message.DEFAULT_PRIORITY, tombstoneTimeToLive);
       }
    }
+
+   @Test
+   public void testMultipleLastValuesCore() throws Exception {
+      testMultipleLastValues(CoreConnection);

Review comment:
       I used the `ConnectionSupplier` because that's what all the other tests in the class use and I find that consistency helps readability. I wouldn't necessarily mind removing the `ConnectionSupplier` altogether, but it's used in around 80 other places so that change is beyond the scope of this PR. All things being equal I think the `ConnectionSupplier` is at least as readable as the alternative you have proposed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org