[GitHub] [arrow] jacques-n commented on a change in pull request #7100: ARROW-8696: [Java] Convert tests to maven failsafe

[GitBox <gi...@apache.org>]

jacques-n commented on a change in pull request #7100:
URL: https://github.com/apache/arrow/pull/7100#discussion_r421885182



##########
File path: java/vector/src/test/java/org/apache/arrow/vector/ITTestLargeVector.java
##########
@@ -45,32 +47,33 @@ private static void testLargeLongVector() {
         BigIntVector largeVec = new BigIntVector("vec", allocator)) {
       largeVec.allocateNew(vecLength);
 
-      System.out.println("Successfully allocated a vector with capacity " + vecLength);
+      logger.info("Successfully allocated a vector with capacity {}", vecLength);
 
       for (int i = 0; i < vecLength; i++) {
         largeVec.set(i, i * 10L);
 
         if ((i + 1) % 10000 == 0) {
-          System.out.println("Successfully written " + (i + 1) + " values");
+          logger.debug("Successfully written {} values", i + 1);
         }
       }
-      System.out.println("Successfully written " + vecLength + " values");
+      logger.info("Successfully written {} values", vecLength);
 
       for (int i = 0; i < vecLength; i++) {
         long val = largeVec.get(i);
         assertEquals(i * 10L, val);
 
         if ((i + 1) % 10000 == 0) {
-          System.out.println("Successfully read " + (i + 1) + " values");
+          logger.debug("Successfully read {} values", i + 1);
         }
       }
-      System.out.println("Successfully read " + vecLength + " values");
+      logger.info("Successfully read {} values", vecLength);

Review comment:
       I suggest you downgrade all these to trace (and those above). They shouldn't really present on normal test runs.

##########
File path: java/memory/src/test/java/org/apache/arrow/memory/ITTestLargeArrowBuf.java
##########
@@ -27,38 +32,45 @@
  *   main method.
  * </p>
  */
-public class TestLargeArrowBuf {
+public class ITTestLargeArrowBuf {
+  private static final Logger logger = LoggerFactory.getLogger(ITTestLargeArrowBuf.class);

Review comment:
       24 and 15. Sounds like we're super consistent. :D
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org