[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them

[GitBox <gi...@apache.org>]

dockerzhang commented on a change in pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#discussion_r815381224



##########
File path: .github/workflows/ci_build_docker.yml
##########
@@ -37,6 +37,11 @@ jobs:
           java-version: 8
           distribution: adopt
 
+      - name: Set up Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: 3.7

Review comment:
       I have tested `2.7.5`, you can test the `docker/get-project-version.py` using `3.7`.

##########
File path: .github/workflows/ci_build_docker.yml
##########
@@ -50,3 +55,11 @@ jobs:
         run: mvn --batch-mode --update-snapshots -e -V clean package -DskipTests -Pdocker
         env:
           CI: false
+
+      - name: Push docker image to Docker Hub
+        if: ${{ success() && github.event_name == 'push' && github.repository == 'apache/incubator-inlong' }}
+        run: sh docker/publish.sh
+        env:
+          DOCKER_USER: ${{ secrets.DOCKER_USER }}
+          DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+          DOCKER_REGISTRY: 'hub.docker.com'

Review comment:
       Does the `DOCKER_REGISTRY` is needless, the default registry is `hub.docker.com`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org