You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by el...@apache.org on 2016/03/08 22:03:20 UTC

[7/7] calcite git commit: [maven-release-plugin] prepare release calcite-avatica-1.7.0-rc0

[maven-release-plugin] prepare release calcite-avatica-1.7.0-rc0


Project: http://git-wip-us.apache.org/repos/asf/calcite/repo
Commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/05251e4d
Tree: http://git-wip-us.apache.org/repos/asf/calcite/tree/05251e4d
Diff: http://git-wip-us.apache.org/repos/asf/calcite/diff/05251e4d

Branch: refs/heads/remote-resources-fixes
Commit: 05251e4da3c0dfc118ee96ab3e193c15499bdbd3
Parents: 237f83b
Author: Josh Elser <el...@apache.org>
Authored: Tue Mar 8 16:02:51 2016 -0500
Committer: Josh Elser <el...@apache.org>
Committed: Tue Mar 8 16:02:51 2016 -0500

----------------------------------------------------------------------
 avatica/core/pom.xml                       | 2 +-
 avatica/metrics-dropwizardmetrics3/pom.xml | 2 +-
 avatica/metrics/pom.xml                    | 2 +-
 avatica/noop-driver/pom.xml                | 2 +-
 avatica/pom.xml                            | 6 +++---
 avatica/server/pom.xml                     | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/calcite/blob/05251e4d/avatica/core/pom.xml
----------------------------------------------------------------------
diff --git a/avatica/core/pom.xml b/avatica/core/pom.xml
index 9ce07f3..356e57c 100644
--- a/avatica/core/pom.xml
+++ b/avatica/core/pom.xml
@@ -20,7 +20,7 @@ limitations under the License.
   <parent>
     <groupId>org.apache.calcite.avatica</groupId>
     <artifactId>calcite-avatica-parent</artifactId>
-    <version>1.7.0-SNAPSHOT</version>
+    <version>1.7.0</version>
   </parent>
 
   <artifactId>calcite-avatica</artifactId>

http://git-wip-us.apache.org/repos/asf/calcite/blob/05251e4d/avatica/metrics-dropwizardmetrics3/pom.xml
----------------------------------------------------------------------
diff --git a/avatica/metrics-dropwizardmetrics3/pom.xml b/avatica/metrics-dropwizardmetrics3/pom.xml
index c96329b..7f3420c 100644
--- a/avatica/metrics-dropwizardmetrics3/pom.xml
+++ b/avatica/metrics-dropwizardmetrics3/pom.xml
@@ -20,7 +20,7 @@ limitations under the License.
   <parent>
     <groupId>org.apache.calcite.avatica</groupId>
     <artifactId>calcite-avatica-parent</artifactId>
-    <version>1.7.0-SNAPSHOT</version>
+    <version>1.7.0</version>
   </parent>
 
   <artifactId>calcite-avatica-metrics-dropwizardmetrics3</artifactId>

http://git-wip-us.apache.org/repos/asf/calcite/blob/05251e4d/avatica/metrics/pom.xml
----------------------------------------------------------------------
diff --git a/avatica/metrics/pom.xml b/avatica/metrics/pom.xml
index b346147..d70614c 100644
--- a/avatica/metrics/pom.xml
+++ b/avatica/metrics/pom.xml
@@ -20,7 +20,7 @@ limitations under the License.
   <parent>
     <groupId>org.apache.calcite.avatica</groupId>
     <artifactId>calcite-avatica-parent</artifactId>
-    <version>1.7.0-SNAPSHOT</version>
+    <version>1.7.0</version>
   </parent>
 
   <artifactId>calcite-avatica-metrics</artifactId>

http://git-wip-us.apache.org/repos/asf/calcite/blob/05251e4d/avatica/noop-driver/pom.xml
----------------------------------------------------------------------
diff --git a/avatica/noop-driver/pom.xml b/avatica/noop-driver/pom.xml
index d50ba37..7798f04 100644
--- a/avatica/noop-driver/pom.xml
+++ b/avatica/noop-driver/pom.xml
@@ -20,7 +20,7 @@ limitations under the License.
   <parent>
     <groupId>org.apache.calcite.avatica</groupId>
     <artifactId>calcite-avatica-parent</artifactId>
-    <version>1.7.0-SNAPSHOT</version>
+    <version>1.7.0</version>
   </parent>
 
   <artifactId>calcite-avatica-noop</artifactId>

http://git-wip-us.apache.org/repos/asf/calcite/blob/05251e4d/avatica/pom.xml
----------------------------------------------------------------------
diff --git a/avatica/pom.xml b/avatica/pom.xml
index 5bccbaf..8bd4b52 100644
--- a/avatica/pom.xml
+++ b/avatica/pom.xml
@@ -22,14 +22,14 @@ limitations under the License.
     <artifactId>apache</artifactId>
     <version>17</version>
     <!-- Tell Maven that it's OK that we're not attached to the parent directory -->
-    <relativePath/>
+    <relativePath />
   </parent>
 
   <!-- The basics. -->
   <groupId>org.apache.calcite.avatica</groupId>
   <artifactId>calcite-avatica-parent</artifactId>
   <packaging>pom</packaging>
-  <version>1.7.0-SNAPSHOT</version>
+  <version>1.7.0</version>
 
   <!-- More project information. -->
   <name>Avatica Project</name>
@@ -101,7 +101,7 @@ limitations under the License.
     <connection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</connection>
     <developerConnection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</developerConnection>
     <url>https://github.com/apache/calcite</url>
-    <tag>HEAD</tag>
+    <tag>calcite-avatica-1.7.0-rc0</tag>
   </scm>
 
   <modules>

http://git-wip-us.apache.org/repos/asf/calcite/blob/05251e4d/avatica/server/pom.xml
----------------------------------------------------------------------
diff --git a/avatica/server/pom.xml b/avatica/server/pom.xml
index 5681c3e..29b7ca4 100644
--- a/avatica/server/pom.xml
+++ b/avatica/server/pom.xml
@@ -20,7 +20,7 @@ limitations under the License.
   <parent>
     <groupId>org.apache.calcite.avatica</groupId>
     <artifactId>calcite-avatica-parent</artifactId>
-    <version>1.7.0-SNAPSHOT</version>
+    <version>1.7.0</version>
   </parent>
 
   <artifactId>calcite-avatica-server</artifactId>


Re: [7/7] calcite git commit: [maven-release-plugin] prepare release calcite-avatica-1.7.0-rc0

Posted by Julian Hyde <jh...@apache.org>.
Yes, the tag in the pom is unimportant. I think it’s a hack to make maven-release-plugin work and has little other purpose. The tag we apply in git after the vote passes, and the commit id that we store elsewhere (e.g. in a vote thread) are more important.

> On Mar 8, 2016, at 2:21 PM, Josh Elser <jo...@gmail.com> wrote:
> 
> Actually, including an rcX in the tag name shouldn't be a problem.
> 
> The important bit is the SHA1 the tag points to. Per the new infra policy, we'll have to make a rel/calcite-avatica-1.7.0 tag. The SHA1 is the important bit, no?
> 
> If it's just a matter of "how we do things", that's fine. Just wanted to make sure I wasn't missing something.
> 
> Josh Elser wrote:
>> Ahh, ok. Will do.
>> 
>> Also, incoming force-push on master. I forgot to switch to a new branch
>> before doing the first Avatica RC.
>> 
>> Julian Hyde wrote:
>>>> On Mar 8, 2016, at 1:03 PM, elserj@apache.org wrote:
>>>> 
>>>> 
>>>> diff --git a/avatica/pom.xml b/avatica/pom.xml
>>>> index 5bccbaf..8bd4b52 100644
>>>> --- a/avatica/pom.xml
>>>> +++ b/avatica/pom.xml
>>>> @@ -101,7 +101,7 @@ limitations under the License.
>>>> <connection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</connection>
>>>> 
>>>> <developerConnection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</developerConnection>
>>>> 
>>>> <url>https://github.com/apache/calcite</url>
>>>> -<tag>HEAD</tag>
>>>> +<tag>calcite-avatica-1.7.0-rc0</tag>
>>>> </scm>
>>> 
>>> 
>>> I’d have used "calcite-avatica-1.7.0” as the tag. At some point one of
>>> those RCs will pass the vote and we won’t be able to go back and
>>> change the tag!
>>> 
>>> Julian
>>> 


Re: [7/7] calcite git commit: [maven-release-plugin] prepare release calcite-avatica-1.7.0-rc0

Posted by Josh Elser <jo...@gmail.com>.
Actually, including an rcX in the tag name shouldn't be a problem.

The important bit is the SHA1 the tag points to. Per the new infra 
policy, we'll have to make a rel/calcite-avatica-1.7.0 tag. The SHA1 is 
the important bit, no?

If it's just a matter of "how we do things", that's fine. Just wanted to 
make sure I wasn't missing something.

Josh Elser wrote:
> Ahh, ok. Will do.
>
> Also, incoming force-push on master. I forgot to switch to a new branch
> before doing the first Avatica RC.
>
> Julian Hyde wrote:
>>> On Mar 8, 2016, at 1:03 PM, elserj@apache.org wrote:
>>>
>>>
>>> diff --git a/avatica/pom.xml b/avatica/pom.xml
>>> index 5bccbaf..8bd4b52 100644
>>> --- a/avatica/pom.xml
>>> +++ b/avatica/pom.xml
>>> @@ -101,7 +101,7 @@ limitations under the License.
>>> <connection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</connection>
>>>
>>> <developerConnection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</developerConnection>
>>>
>>> <url>https://github.com/apache/calcite</url>
>>> -<tag>HEAD</tag>
>>> +<tag>calcite-avatica-1.7.0-rc0</tag>
>>> </scm>
>>
>>
>> I’d have used "calcite-avatica-1.7.0” as the tag. At some point one of
>> those RCs will pass the vote and we won’t be able to go back and
>> change the tag!
>>
>> Julian
>>

Re: [7/7] calcite git commit: [maven-release-plugin] prepare release calcite-avatica-1.7.0-rc0

Posted by Josh Elser <jo...@gmail.com>.
Ahh, ok. Will do.

Also, incoming force-push on master. I forgot to switch to a new branch 
before doing the first Avatica RC.

Julian Hyde wrote:
>> On Mar 8, 2016, at 1:03 PM, elserj@apache.org wrote:
>>
>>
>> diff --git a/avatica/pom.xml b/avatica/pom.xml
>> index 5bccbaf..8bd4b52 100644
>> --- a/avatica/pom.xml
>> +++ b/avatica/pom.xml
>> @@ -101,7 +101,7 @@ limitations under the License.
>>      <connection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</connection>
>>      <developerConnection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</developerConnection>
>>      <url>https://github.com/apache/calcite</url>
>> -<tag>HEAD</tag>
>> +<tag>calcite-avatica-1.7.0-rc0</tag>
>>    </scm>
>
>
> I’d have used "calcite-avatica-1.7.0” as the tag. At some point one of those RCs will pass the vote and we won’t be able to go back and change the tag!
>
> Julian
>

Re: [7/7] calcite git commit: [maven-release-plugin] prepare release calcite-avatica-1.7.0-rc0

Posted by Julian Hyde <jh...@apache.org>.
> On Mar 8, 2016, at 1:03 PM, elserj@apache.org wrote:
> 
> 
> diff --git a/avatica/pom.xml b/avatica/pom.xml
> index 5bccbaf..8bd4b52 100644
> --- a/avatica/pom.xml
> +++ b/avatica/pom.xml
> @@ -101,7 +101,7 @@ limitations under the License.
>     <connection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</connection>
>     <developerConnection>scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git</developerConnection>
>     <url>https://github.com/apache/calcite</url>
> -    <tag>HEAD</tag>
> +    <tag>calcite-avatica-1.7.0-rc0</tag>
>   </scm>


I’d have used "calcite-avatica-1.7.0” as the tag. At some point one of those RCs will pass the vote and we won’t be able to go back and change the tag!

Julian