[GitHub] Mogball commented on issue #3429: Deleting filters clears all following filters

[gi...@git.apache.org]

Mogball commented on issue #3429: Deleting filters clears all following filters
URL: https://github.com/apache/incubator-superset/issues/3429#issuecomment-329248024
 
 
   The bug seems to be the result of how the UI widgets are handled. 
   
   Clicking the remove button will modify the prop `value` of `FilterControl` but the `Filter` components are not updating the choices for their value selection boxes. The filters appear cleared on the UI (but are actually still in effect) because the value selection box will not display the selected values if they conflict with the available choices. 
   
   Triggering a refresh, e.g. by selecting a column in the filter, will properly display the widget. 
   
   I've managed to solve this issue by storing the selection choices for each filter in `FilterControl` instead of `Filter`, making AJAX calls only when a filter column changes or when adding a new filter, and passing these choices as props.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services