You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sandesha-dev@ws.apache.org by "Matt Lovett (JIRA)" <ji...@apache.org> on 2006/11/02 11:10:16 UTC
[jira] Created: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Extend SecurityManager to add 'apply' method
--------------------------------------------
Key: SANDESHA2-38
URL: http://issues.apache.org/jira/browse/SANDESHA2-38
Project: Apache Sandesha2
Issue Type: Improvement
Reporter: Matt Lovett
Attachments: apply.patch
We have an implementation of the SecurityManager that needs to put some token-related properties
onto the message context for each RM message. The obvious way to achieve this is to add a new
method like:
public void apply(SecurityToken token, MessageContext outboundMessage)
to the SecurityManager interface.
I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=all ]
Matt Lovett updated SANDESHA2-38:
---------------------------------
Attachment: apply.patch
Here's the patch that I described when I opened the Jira.
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Resolved: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=all ]
Matt Lovett resolved SANDESHA2-38.
----------------------------------
Resolution: Fixed
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=comments#action_12446780 ]
Chamikara Jayalath commented on SANDESHA2-38:
---------------------------------------------
Hi Matt,
One question. What was the reason for removing 'initializaCreation' and 'finalizeCreation' methods of the RMMsgCreator ?
Chamikara
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Resolved: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=all ]
Matt Lovett resolved SANDESHA2-38.
----------------------------------
Resolution: Fixed
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=all ]
Matt Lovett updated SANDESHA2-38:
---------------------------------
Attachment: apply.patch
Here's the patch that I described when I opened the Jira.
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=comments#action_12446872 ]
Matt Lovett commented on SANDESHA2-38:
--------------------------------------
Hi Chamikara,
I'm sorry, I guess I was a bit sloppy - I folded in some cleanup at the same time. Now that we are using Operations that have been located within the AxisService instead of 'new'ing them up each time we need a lot less copying of properties etc. I believe the change is safe - it didn't break any of the unit tests.
If you know of some properties that do need to be copied, perhaps we can some up with a cleaner way of handing them without blindly copying everything - perhaps a new plug point would make sense.
Equally, it's not critical to clean those methods up right now, so if you like you could apply the rest of the patch. It will work either way.
Thanks
Matt
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=comments#action_12446888 ]
Chamikara Jayalath commented on SANDESHA2-38:
---------------------------------------------
No it seems ok to me. Applied the patch.
Chamikara
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=comments#action_12446872 ]
Matt Lovett commented on SANDESHA2-38:
--------------------------------------
Hi Chamikara,
I'm sorry, I guess I was a bit sloppy - I folded in some cleanup at the same time. Now that we are using Operations that have been located within the AxisService instead of 'new'ing them up each time we need a lot less copying of properties etc. I believe the change is safe - it didn't break any of the unit tests.
If you know of some properties that do need to be copied, perhaps we can some up with a cleaner way of handing them without blindly copying everything - perhaps a new plug point would make sense.
Equally, it's not critical to clean those methods up right now, so if you like you could apply the rest of the patch. It will work either way.
Thanks
Matt
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=comments#action_12446888 ]
Chamikara Jayalath commented on SANDESHA2-38:
---------------------------------------------
No it seems ok to me. Applied the patch.
Chamikara
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-38) Extend SecurityManager to add
'apply' method
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=comments#action_12446780 ]
Chamikara Jayalath commented on SANDESHA2-38:
---------------------------------------------
Hi Matt,
One question. What was the reason for removing 'initializaCreation' and 'finalizeCreation' methods of the RMMsgCreator ?
Chamikara
> Extend SecurityManager to add 'apply' method
> --------------------------------------------
>
> Key: SANDESHA2-38
> URL: http://issues.apache.org/jira/browse/SANDESHA2-38
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Attachments: apply.patch
>
>
> We have an implementation of the SecurityManager that needs to put some token-related properties
> onto the message context for each RM message. The obvious way to achieve this is to add a new
> method like:
> public void apply(SecurityToken token, MessageContext outboundMessage)
> to the SecurityManager interface.
> I'll attach a patch that does this, as well as fix up the various SecurityManager impls. I'll also take the
> chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add a header into the message,
> which allows us to implement a better 'checkProofOfPossession' method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org