[GitHub] [jena] rvesse commented on pull request #1083: JENA-2178: Generalize service loading

[GitBox <gi...@apache.org>]

rvesse commented on pull request #1083:
URL: https://github.com/apache/jena/pull/1083#issuecomment-946474233


   Since we're generalising this mechanism a couple of things jump out to me:
   
   - Do we want to force initialisers of the same level to run in a predictable order likely by breaking the comparison tie with a lexical comparison on class name.  That way if folks are using this mechanism and (un)intentionally use the same level as a system module the order of operations remains predictable.  This seems particularly important since this PR increases the range of levels considered to be Jena system so pre-existing initialisers might get bitten by this.
   - A bare `sl.forEach()` without any exception handling is going to throw an exception should it encounter an unloadable class likely leading to a) a JVM exit with nasty stack trace or b) silently carrying on in a partially initialised state without any obvious indication to the user depending on how and when initialisation is getting called.  Some explicit error handling and bail out may be warranted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org