You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chukwa.apache.org by "jaydeep ayachit (JIRA)" <ji...@apache.org> on 2010/09/28 16:00:33 UTC
[jira] Created: (CHUKWA-525) Extending DirTailing Adapter
Extending DirTailing Adapter
----------------------------
Key: CHUKWA-525
URL: https://issues.apache.org/jira/browse/CHUKWA-525
Project: Chukwa
Issue Type: Improvement
Components: data collection
Affects Versions: 0.4.0, 0.3.0
Reporter: jaydeep ayachit
Fix For: 0.4.0, 0.3.0
This enhancement is to allow extend DirTailingAdaptor that can support custom build adaptors. Its assumed that custom adaptors will be built and shipped in a separate jar file. Following changes suggested in DirTailingAdaptor
- String adaptorName: protected to allow extending adaptors know underlying file level adaptor
- protected String getAdaptorAddCommand(File dir) throws IOException: New method: Allows to construct add command based on custom adaptor to be used with custom DirTailing adaptor
- private void scanDirHierarchy(File dir): call getAdaptorAddCommand to get adaptor to add. This allows to pass on custom adaptor specific arguments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (CHUKWA-525) Extending DirTailing Adapter
Posted by Bernd Fondermann <be...@googlemail.com>.
On Thu, Oct 28, 2010 at 14:48, jaydeep ayachit (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/CHUKWA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925793#action_12925793 ]
>
> jaydeep ayachit commented on CHUKWA-525:
> ----------------------------------------
>
> Ari, could you please review the patch and let me know if its ok to commit.
All committers are equal. Why do we wait on each other to do something
simple as committing a patch?
Please, can't we establish a more agile process?
I propose that if someone uploads a patch, to wait for 24hrs and then
commit right away if nobody raises his voice.
This is still a magnitude more complicated than it needs to be.
Commits can be reverted at any time, there's no risk in committing.
(Sidenode: Hadoop itself uses the same approach and is basically
stalled since month for this very reason, besides others)
Bernd
[jira] Commented: (CHUKWA-525) Extending DirTailing Adapter
Posted by "jaydeep ayachit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925793#action_12925793 ]
jaydeep ayachit commented on CHUKWA-525:
----------------------------------------
Ari, could you please review the patch and let me know if its ok to commit.
Thanks
Jaydeep
> Extending DirTailing Adapter
> ----------------------------
>
> Key: CHUKWA-525
> URL: https://issues.apache.org/jira/browse/CHUKWA-525
> Project: Chukwa
> Issue Type: Improvement
> Components: data collection
> Affects Versions: 0.3.0, 0.4.0
> Reporter: jaydeep ayachit
> Fix For: 0.3.0, 0.4.0
>
> Attachments: DirTailingAdaptor.patch
>
>
> This enhancement is to allow extend DirTailingAdaptor that can support custom build adaptors. Its assumed that custom adaptors will be built and shipped in a separate jar file. Following changes suggested in DirTailingAdaptor
> - String adaptorName: protected to allow extending adaptors know underlying file level adaptor
> - protected String getAdaptorAddCommand(File dir) throws IOException: New method: Allows to construct add command based on custom adaptor to be used with custom DirTailing adaptor
> - private void scanDirHierarchy(File dir): call getAdaptorAddCommand to get adaptor to add. This allows to pass on custom adaptor specific arguments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-525) Extending DirTailing Adapter
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921464#action_12921464 ]
Ari Rabkin commented on CHUKWA-525:
-----------------------------------
Jaydeep, did you mean to attach a patch here?
> Extending DirTailing Adapter
> ----------------------------
>
> Key: CHUKWA-525
> URL: https://issues.apache.org/jira/browse/CHUKWA-525
> Project: Chukwa
> Issue Type: Improvement
> Components: data collection
> Affects Versions: 0.3.0, 0.4.0
> Reporter: jaydeep ayachit
> Fix For: 0.3.0, 0.4.0
>
>
> This enhancement is to allow extend DirTailingAdaptor that can support custom build adaptors. Its assumed that custom adaptors will be built and shipped in a separate jar file. Following changes suggested in DirTailingAdaptor
> - String adaptorName: protected to allow extending adaptors know underlying file level adaptor
> - protected String getAdaptorAddCommand(File dir) throws IOException: New method: Allows to construct add command based on custom adaptor to be used with custom DirTailing adaptor
> - private void scanDirHierarchy(File dir): call getAdaptorAddCommand to get adaptor to add. This allows to pass on custom adaptor specific arguments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-525) Extending DirTailing Adapter
Posted by "jaydeep ayachit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
jaydeep ayachit updated CHUKWA-525:
-----------------------------------
Attachment: DirTailingAdaptor.patch
Attached is the patch. Please review and let me know if anything needs to be added.
> Extending DirTailing Adapter
> ----------------------------
>
> Key: CHUKWA-525
> URL: https://issues.apache.org/jira/browse/CHUKWA-525
> Project: Chukwa
> Issue Type: Improvement
> Components: data collection
> Affects Versions: 0.3.0, 0.4.0
> Reporter: jaydeep ayachit
> Fix For: 0.3.0, 0.4.0
>
> Attachments: DirTailingAdaptor.patch
>
>
> This enhancement is to allow extend DirTailingAdaptor that can support custom build adaptors. Its assumed that custom adaptors will be built and shipped in a separate jar file. Following changes suggested in DirTailingAdaptor
> - String adaptorName: protected to allow extending adaptors know underlying file level adaptor
> - protected String getAdaptorAddCommand(File dir) throws IOException: New method: Allows to construct add command based on custom adaptor to be used with custom DirTailing adaptor
> - private void scanDirHierarchy(File dir): call getAdaptorAddCommand to get adaptor to add. This allows to pass on custom adaptor specific arguments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-525) Extending DirTailing Adapter
Posted by "jaydeep ayachit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
jaydeep ayachit updated CHUKWA-525:
-----------------------------------
Status: Patch Available (was: Open)
> Extending DirTailing Adapter
> ----------------------------
>
> Key: CHUKWA-525
> URL: https://issues.apache.org/jira/browse/CHUKWA-525
> Project: Chukwa
> Issue Type: Improvement
> Components: data collection
> Affects Versions: 0.4.0, 0.3.0
> Reporter: jaydeep ayachit
> Fix For: 0.4.0, 0.3.0
>
> Attachments: DirTailingAdaptor.patch
>
>
> This enhancement is to allow extend DirTailingAdaptor that can support custom build adaptors. Its assumed that custom adaptors will be built and shipped in a separate jar file. Following changes suggested in DirTailingAdaptor
> - String adaptorName: protected to allow extending adaptors know underlying file level adaptor
> - protected String getAdaptorAddCommand(File dir) throws IOException: New method: Allows to construct add command based on custom adaptor to be used with custom DirTailing adaptor
> - private void scanDirHierarchy(File dir): call getAdaptorAddCommand to get adaptor to add. This allows to pass on custom adaptor specific arguments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-525) Extending DirTailing Adapter
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin updated CHUKWA-525:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Looks good. I just committed this. Thanks, Jaydeep!
> Extending DirTailing Adapter
> ----------------------------
>
> Key: CHUKWA-525
> URL: https://issues.apache.org/jira/browse/CHUKWA-525
> Project: Chukwa
> Issue Type: Improvement
> Components: data collection
> Affects Versions: 0.3.0, 0.4.0
> Reporter: jaydeep ayachit
> Fix For: 0.4.0, 0.3.0
>
> Attachments: DirTailingAdaptor.patch
>
>
> This enhancement is to allow extend DirTailingAdaptor that can support custom build adaptors. Its assumed that custom adaptors will be built and shipped in a separate jar file. Following changes suggested in DirTailingAdaptor
> - String adaptorName: protected to allow extending adaptors know underlying file level adaptor
> - protected String getAdaptorAddCommand(File dir) throws IOException: New method: Allows to construct add command based on custom adaptor to be used with custom DirTailing adaptor
> - private void scanDirHierarchy(File dir): call getAdaptorAddCommand to get adaptor to add. This allows to pass on custom adaptor specific arguments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.