You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by us...@apache.org on 2013/04/19 22:30:57 UTC
svn commit: r1470026 - in /lucene/dev/branches/branch_4x: ./ lucene/
lucene/tools/ lucene/tools/forbiddenApis/executors.txt
lucene/tools/forbiddenApis/servlet-api.txt
lucene/tools/forbiddenApis/tests.txt
Author: uschindler
Date: Fri Apr 19 20:30:57 2013
New Revision: 1470026
URL: http://svn.apache.org/r1470026
Log:
Merged revision(s) 1470024 from lucene/dev/trunk:
Make the Lucene/Solr-provided forbidden api signature files use the new syntax in the forbidden-apis ANT task and provide a useful message
Modified:
lucene/dev/branches/branch_4x/ (props changed)
lucene/dev/branches/branch_4x/lucene/ (props changed)
lucene/dev/branches/branch_4x/lucene/tools/ (props changed)
lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/executors.txt
lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/servlet-api.txt
lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/tests.txt
Modified: lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/executors.txt
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/executors.txt?rev=1470026&r1=1470025&r2=1470026&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/executors.txt (original)
+++ lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/executors.txt Fri Apr 19 20:30:57 2013
@@ -13,11 +13,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# These methods spawn threads with vague names. Use a custom thread factory and name
-# threads so that you can tell (by its name) which executor it is associated with.
# see Solr's DefaultSolrThreadFactory
# see Lucene's NamedThreadFactory
+@defaultMessage spawns threads with vague names; use a custom thread factory and name threads so that you can tell (by its name) which executor it is associated with
+
java.util.concurrent.Executors#newFixedThreadPool(int)
java.util.concurrent.Executors#newSingleThreadExecutor()
java.util.concurrent.Executors#newCachedThreadPool()
Modified: lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/servlet-api.txt
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/servlet-api.txt?rev=1470026&r1=1470025&r2=1470026&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/servlet-api.txt (original)
+++ lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/servlet-api.txt Fri Apr 19 20:30:57 2013
@@ -13,17 +13,17 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# These methods from the Servlet API should not be used, because they are
-# either broken and slow in some environments (e.g., Jetty's UTF-8 readers),
-# or the parsing of request parameters is not using the correct encoding
-# without extra configuration in the servlet container:
-javax.servlet.ServletRequest#getReader()
+@defaultMessage Servlet API method is parsing request parameters without using the correct encoding if no extra configuration is given in the servlet container
+
javax.servlet.ServletRequest#getParameter(java.lang.String)
javax.servlet.ServletRequest#getParameterMap()
javax.servlet.ServletRequest#getParameterNames()
javax.servlet.ServletRequest#getParameterValues(java.lang.String)
-javax.servlet.ServletResponse#getWriter()
+@defaultMessage Servlet API method is broken and slow in some environments (e.g., Jetty's UTF-8 readers)
+
+javax.servlet.ServletRequest#getReader()
+javax.servlet.ServletResponse#getWriter()
javax.servlet.ServletInputStream#readLine(byte[],int,int)
javax.servlet.ServletOutputStream#print(boolean)
javax.servlet.ServletOutputStream#print(char)
Modified: lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/tests.txt
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/tests.txt?rev=1470026&r1=1470025&r2=1470026&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/tests.txt (original)
+++ lucene/dev/branches/branch_4x/lucene/tools/forbiddenApis/tests.txt Fri Apr 19 20:30:57 2013
@@ -13,13 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# All classes should derive from LuceneTestCase
-junit.framework.TestCase
+junit.framework.TestCase @ All classes should derive from LuceneTestCase
-# Use RandomizedRunner's random instead
-java.util.Random#<init>()
+java.util.Random#<init>() @ Use RandomizedRunner's random instead
-# Don't depend on wall clock times
# TODO: fix tests that do this!
-#java.lang.System#currentTimeMillis()
-#java.lang.System#nanoTime()
+#java.lang.System#currentTimeMillis() @ Don't depend on wall clock times
+#java.lang.System#nanoTime() @ Don't depend on wall clock times