[GitHub] [lucene] uschindler edited a comment on pull request #367: LUCENE-10129: Add RamUsageEstimator.shallowSizeOf() for primitive arrays

[GitBox <gi...@apache.org>]

uschindler edited a comment on pull request #367:
URL: https://github.com/apache/lucene/pull/367#issuecomment-944245850


   There was a comment on the issue, which also confused me (a problem in the test):
   
   > I am wondering though if TestRamUsageEstimator is missing an import static org.apache.lucene.util.RamUsageEstimator.sizeOf;, so that in lines like assertEquals(sizeOf(array), sizeOf((Object) array)); the first sizeOf() calls RamUsageEstimator.sizeOf, and the second calls RamUsageTester.sizeOf. Apologies if I misunderstood the purpose of the test.
   
   I was also stumbling on this. Maybe we should remove the static import and be explicit and compare all three versions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org