You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/28 15:01:52 UTC

[GitHub] [incubator-nuttx] juniskane opened a new pull request #2146: drivers/pipes: nx_pipe syscall takes three params, also use nx_close …

juniskane opened a new pull request #2146:
URL: https://github.com/apache/incubator-nuttx/pull/2146


   ## Summary
   
   - Fix SYSCALL_LOOKUP for nx_pipe syscall
   - Use nx_close() instead of close() to avoid setting errno and cancellation point
   - Update some misleading comments
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2146: drivers/pipes: nx_pipe syscall takes three params, also use nx_close …

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2146:
URL: https://github.com/apache/incubator-nuttx/pull/2146#discussion_r513518572



##########
File path: include/sys/syscall_lookup.h
##########
@@ -255,7 +255,7 @@ SYSCALL_LOOKUP(telldir,                    1)
 #endif
 
 #if defined(CONFIG_PIPES) && CONFIG_DEV_PIPE_SIZE > 0
-  SYSCALL_LOOKUP(nx_pipe,                  2)
+  SYSCALL_LOOKUP(nx_pipe,                  3)

Review comment:
       dup with nx_mkfifo




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2146: drivers/pipes: nx_pipe syscall takes three params, also use nx_close …

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2146:
URL: https://github.com/apache/incubator-nuttx/pull/2146


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org