You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/07/08 02:24:56 UTC
Re: Review Request 36273: Doxygen-ification of comments in libprocess
process headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/
-----------------------------------------------------------
(Updated July 7, 2015, 5:24 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
Repository: mesos
Description
-------
Doxygen-ification of comments in libprocess process headers.
Diffs
-----
3rdparty/libprocess/include/process/process.hpp 59b50af86e059463a01f3c83701bc5fd143d51a4
Diff: https://reviews.apache.org/r/36273/diff/
Testing
-------
`doxygen ../Doxyfile` and visually verified the HTML output.
Thanks,
Joseph Wu
Re: Review Request 36273: Doxygen-ification of comments in libprocess
process headers.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/#review91098
-----------------------------------------------------------
Ship it!
After fixing the above comments...
- Joerg Schad
On July 8, 2015, 12:24 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36273/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 12:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Doxygen-ification of comments in libprocess process headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp 59b50af86e059463a01f3c83701bc5fd143d51a4
>
> Diff: https://reviews.apache.org/r/36273/diff/
>
>
> Testing
> -------
>
> `doxygen ../Doxyfile` and visually verified the HTML output.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 36273: Doxygen-ification of comments in libprocess
process headers.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On July 9, 2015, 5:49 a.m., Joerg Schad wrote:
> > 3rdparty/libprocess/include/process/process.hpp, line 40
> > <https://reviews.apache.org/r/36273/diff/1/?file=1001721#file1001721line40>
> >
> > /s/**Note**:/**NOTE:**
The "NOTE" is already in all caps, as per the Markdown style guide:
https://github.com/apache/mesos/blob/master/docs/mesos-markdown-style-guide.md#notesemphasis
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/#review91096
-----------------------------------------------------------
On July 7, 2015, 5:24 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36273/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 5:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Doxygen-ification of comments in libprocess process headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp 59b50af86e059463a01f3c83701bc5fd143d51a4
>
> Diff: https://reviews.apache.org/r/36273/diff/
>
>
> Testing
> -------
>
> `doxygen ../Doxyfile` and visually verified the HTML output.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 36273: Doxygen-ification of comments in libprocess
process headers.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/#review91096
-----------------------------------------------------------
3rdparty/libprocess/include/process/process.hpp (line 40)
<https://reviews.apache.org/r/36273/#comment144360>
/s/**Note**:/**NOTE:**
3rdparty/libprocess/include/process/process.hpp (line 83)
<https://reviews.apache.org/r/36273/#comment144361>
That seems very long for the brief description... Feel free to drop though...
3rdparty/libprocess/include/process/process.hpp (line 407)
<https://reviews.apache.org/r/36273/#comment144362>
see above
3rdparty/libprocess/include/process/process.hpp (line 423)
<https://reviews.apache.org/r/36273/#comment144363>
the comma seems off here...
3rdparty/libprocess/include/process/process.hpp (line 425)
<https://reviews.apache.org/r/36273/#comment144364>
I know you didn't touch this directly, but as you touched the comment block anyhow could you add a perdiod at the end?
- Joerg Schad
On July 8, 2015, 12:24 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36273/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 12:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Doxygen-ification of comments in libprocess process headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp 59b50af86e059463a01f3c83701bc5fd143d51a4
>
> Diff: https://reviews.apache.org/r/36273/diff/
>
>
> Testing
> -------
>
> `doxygen ../Doxyfile` and visually verified the HTML output.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 36273: Doxygen-ification of comments in libprocess
process headers.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/#review91220
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 9, 2015, 4:49 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36273/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 4:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Doxygen-ification of comments in libprocess process headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp 59b50af86e059463a01f3c83701bc5fd143d51a4
>
> Diff: https://reviews.apache.org/r/36273/diff/
>
>
> Testing
> -------
>
> `doxygen ../Doxyfile` and visually verified the HTML output.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 36273: Doxygen-ification of comments in libprocess
process headers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/#review91140
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36273]
All tests passed.
- Mesos ReviewBot
On July 9, 2015, 4:49 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36273/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 4:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Doxygen-ification of comments in libprocess process headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp 59b50af86e059463a01f3c83701bc5fd143d51a4
>
> Diff: https://reviews.apache.org/r/36273/diff/
>
>
> Testing
> -------
>
> `doxygen ../Doxyfile` and visually verified the HTML output.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 36273: Doxygen-ification of comments in libprocess
process headers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/
-----------------------------------------------------------
(Updated July 9, 2015, 9:49 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
Changes
-------
Re-word comment over "finalize". Add periods at the end of some @param declarations.
Repository: mesos
Description
-------
Doxygen-ification of comments in libprocess process headers.
Diffs (updated)
-----
3rdparty/libprocess/include/process/process.hpp 59b50af86e059463a01f3c83701bc5fd143d51a4
Diff: https://reviews.apache.org/r/36273/diff/
Testing
-------
`doxygen ../Doxyfile` and visually verified the HTML output.
Thanks,
Joseph Wu
Re: Review Request 36273: Doxygen-ification of comments in libprocess
process headers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/#review90852
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36273]
All tests passed.
- Mesos ReviewBot
On July 8, 2015, 12:24 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36273/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 12:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Doxygen-ification of comments in libprocess process headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp 59b50af86e059463a01f3c83701bc5fd143d51a4
>
> Diff: https://reviews.apache.org/r/36273/diff/
>
>
> Testing
> -------
>
> `doxygen ../Doxyfile` and visually verified the HTML output.
>
>
> Thanks,
>
> Joseph Wu
>
>