You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liancheng <gi...@git.apache.org> on 2016/03/01 12:36:21 UTC

[GitHub] spark pull request: [SPARK-13553][SPARK-13554][SQL] Migrates basic...

Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11431#discussion_r54555140
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ---
    @@ -627,6 +662,181 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
           Seq(OuterObject.InnerClass("foo")).toDS(),
           OuterObject.InnerClass("foo"))
       }
    +
    +  /////////////////////////////////////////////////////////////////////////////
    +  // Tests for operations migrated from DataFrame
    +  /////////////////////////////////////////////////////////////////////////////
    +
    +  test("column selection") {
    +    val df = Seq(Tuple1(1)).toDS().as("t")
    +    // We should allow empty string as column name
    --- End diff --
    
    Copy paste error. Should remove this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org