You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org> on 2017/12/06 01:55:00 UTC

[jira] [Commented] (RATIS-131) Add checkstyle configuration

    [ https://issues.apache.org/jira/browse/RATIS-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279530#comment-16279530 ] 

Tsz Wo Nicholas Sze commented on RATIS-131:
-------------------------------------------

We probably want to modify the following checkstyle warnings:
- Missing a Javadoc comment.
It should only apply to public APIs.
- Redundant 'final' modifier.
It seems not a bad thing to have "final" even if it is implicitly final.
- 80 character line limit.
It is too narrow for the modern computer screens.  Let's make it at least 120.

> Add checkstyle configuration
> ----------------------------
>
>                 Key: RATIS-131
>                 URL: https://issues.apache.org/jira/browse/RATIS-131
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: Tsz Wo Nicholas Sze
>
> This JIRA is to setup our checkstyle coding conventions.  We probably should start with the [Sun coding conventions|https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)