You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/29 20:12:16 UTC

[GitHub] [maven] Giovds commented on a diff in pull request #701: [MNG-7443] Make logging consistent between optional profiles and projects

Giovds commented on code in PR #701:
URL: https://github.com/apache/maven/pull/701#discussion_r910373496


##########
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java:
##########
@@ -254,12 +215,13 @@ private List<MavenProject> trimResumedProjects( List<MavenProject> projects, Pro
 
         if ( StringUtils.isNotEmpty( request.getResumeFrom() ) )
         {
-            File reactorDirectory = getReactorDirectory( request );
+            File reactorDirectory = !isNullOrEmpty( request.getBaseDirectory() )

Review Comment:
   Good catch, you are right. It was intended to be the follow the [original implementation](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java#L436) but slipped through.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org