[GitHub] [arrow] ianmcook commented on a change in pull request #9950: ARROW-11468: [R] Allow user to pass schema to read_json_arrow()

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #9950:
URL: https://github.com/apache/arrow/pull/9950#discussion_r610652455



##########
File path: r/src/json.cpp
##########
@@ -31,14 +31,24 @@ std::shared_ptr<arrow::json::ReadOptions> json___ReadOptions__initialize(bool us
 }
 
 // [[arrow::export]]
-std::shared_ptr<arrow::json::ParseOptions> json___ParseOptions__initialize(
+std::shared_ptr<arrow::json::ParseOptions> json___ParseOptions__initialize1(
     bool newlines_in_values) {
   auto res =
       std::make_shared<arrow::json::ParseOptions>(arrow::json::ParseOptions::Defaults());
   res->newlines_in_values = newlines_in_values;
   return res;
 }
 
+// [[arrow::export]]
+std::shared_ptr<arrow::json::ParseOptions> json___ParseOptions__initialize2(
+    bool newlines_in_values, const std::shared_ptr<arrow::Schema>& explicit_schema) {
+  auto res =
+    std::make_shared<arrow::json::ParseOptions>(arrow::json::ParseOptions::Defaults());
+  res->newlines_in_values = newlines_in_values;
+  res->explicit_schema = explicit_schema;
+  return res;
+}
+

Review comment:
       Possibly silly question because I'm a C++ noob:
   Would it work to keep this as just one function `json___ParseOptions__initialize` with `explicit_schema` defaulting to `nullptr` and then do
   ```cpp
   if (explicit_schema != nullptr) {
     res->explicit_schema = explicit_schema;
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org