[GitHub] [ozone] smengcl commented on a diff in pull request #4011: HDDS-5331. Recon: Trigger PipelineSyncTask when DN becomes stale and ContainerHealthTask when DN becomes dead.

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #4011:
URL: https://github.com/apache/ozone/pull/4011#discussion_r1048870810


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java:
##########
@@ -108,6 +97,30 @@ public synchronized void run() {
     }
   }
 
+  public void triggerContainerHealthCheck() {
+    try {
+      lock.writeLock().lock();

Review Comment:
   We typically `lock()` right above `try`:
   ```suggestion
       lock.writeLock().lock();
       try {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org