You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/08 03:19:09 UTC

[GitHub] [flink] ZmmBigdata opened a new pull request, #20983: [FLINK-29458][docs] When two tables have the same field, do not speci…

ZmmBigdata opened a new pull request, #20983:
URL: https://github.com/apache/flink/pull/20983

   ## What is the purpose of the change
   
   When two tables have the same field, do not specify the table name,Exception will be thrown:SqlValidatorException :Column 'currency' is ambiguous.
   
   The page url is https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/table/sql/queries/joins/
   
   
   ## Brief change log
   
   *The table name is added before the query field,“ orders.currency”*
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented?  no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] ZmmBigdata commented on pull request #20983: [FLINK-29458][docs] When two tables have the same field, do not speci…

Posted by GitBox <gi...@apache.org>.
ZmmBigdata commented on PR #20983:
URL: https://github.com/apache/flink/pull/20983#issuecomment-1279766335

   
   
   
   > @ZmmBigdata Thanks for fixing this! It's better to fix the chinese version (though it hasn't been translated yet) `docs/content.zh/docs/dev/table/sql/queries/joins.md` as well.
   
   @lincoln-lil Can you merge this first? I'll change the Chinese document,I want a contributor,hhh


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] wuchong merged pull request #20983: [FLINK-29458][docs] When two tables have the same field, do not speci…

Posted by GitBox <gi...@apache.org>.
wuchong merged PR #20983:
URL: https://github.com/apache/flink/pull/20983


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #20983: [FLINK-29458][docs] When two tables have the same field, do not speci…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20983:
URL: https://github.com/apache/flink/pull/20983#issuecomment-1272212106

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9d25c8e5d1ac05cf3465b2f509fd90c8a6bc35b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9d25c8e5d1ac05cf3465b2f509fd90c8a6bc35b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d25c8e5d1ac05cf3465b2f509fd90c8a6bc35b0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] lincoln-lil commented on pull request #20983: [FLINK-29458][docs] When two tables have the same field, do not speci…

Posted by GitBox <gi...@apache.org>.
lincoln-lil commented on PR #20983:
URL: https://github.com/apache/flink/pull/20983#issuecomment-1272230868

   @ZmmBigdata Thanks for fixing this! It's better to fix  the chinese version (though it hasn't been translated yet) `docs/content.zh/docs/dev/table/sql/queries/joins.md` as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org