You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2022/05/19 01:14:53 UTC

[impala] branch master updated (22272fb5d -> 6ea15409b)

This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


    from 22272fb5d IMPALA-10465, IMPALA-10699: Bump up native-toolchain
     new 1f89627b9 IMPALA-11300: [DOCS] Fix Iceberg documentation links
     new 6ea15409b IMPALA-11208: Fix uninitialized counter of CollectionItemsRead in orc-scanner

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 be/src/exec/hdfs-orc-scanner.h                                    | 2 +-
 docs/topics/impala_iceberg.xml                                    | 8 ++++----
 .../QueryTest/nested-types-scanner-array-materialization.test     | 8 ++++++++
 .../functional-query/queries/QueryTest/nested-types-tpch.test     | 2 ++
 testdata/workloads/tpch/queries/tpch-q1.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q10.test                     | 2 ++
 testdata/workloads/tpch/queries/tpch-q11.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q12.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q13.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q14.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q15.test                     | 2 ++
 testdata/workloads/tpch/queries/tpch-q16.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q17.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q18.test                     | 2 ++
 testdata/workloads/tpch/queries/tpch-q19.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q2.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q20.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q21.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q22.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q3.test                      | 2 ++
 testdata/workloads/tpch/queries/tpch-q4.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q5.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q6.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q7.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q8.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q9.test                      | 4 +++-
 26 files changed, 77 insertions(+), 23 deletions(-)


[impala] 01/02: IMPALA-11300: [DOCS] Fix Iceberg documentation links

Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 1f89627b9e2e92e05a7d504cdd141054de42eb2a
Author: Tamas Mate <tm...@apache.org>
AuthorDate: Wed May 18 13:52:23 2022 +0200

    IMPALA-11300: [DOCS] Fix Iceberg documentation links
    
    This commit updates the links that point to the Iceberg doc site.
    
    Testing:
     - Built the docs and checked the links.
    
    Change-Id: I6ee820d43ebaac2415f0256d34ccc6e0300aff0c
    Reviewed-on: http://gerrit.cloudera.org:8080/18539
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
 docs/topics/impala_iceberg.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/topics/impala_iceberg.xml b/docs/topics/impala_iceberg.xml
index 384503808..aa162b6ca 100644
--- a/docs/topics/impala_iceberg.xml
+++ b/docs/topics/impala_iceberg.xml
@@ -235,7 +235,7 @@ CREATE TABLE ice_ctas_part_spec PARTITIONED BY SPEC (truncate(3, s)) STORED AS I
 
       <p>
         You can get information about the supported Iceberg data tyeps in
-        <xref href="https://iceberg.apache.org/#spec/%23schemas-and-data-types" scope="external" format="html">
+        <xref href="https://iceberg.apache.org/docs/latest/schemas/" scope="external" format="html">
           the Iceberg spec</xref>.
       </p>
 
@@ -352,7 +352,7 @@ CREATE TABLE ice_ctas_part_spec PARTITIONED BY SPEC (truncate(3, s)) STORED AS I
       </p>
       <p>
         See
-        <xref href="https://iceberg.apache.org/#spec/%23schema-evolution" scope="external" format="html">
+        <xref href="https://iceberg.apache.org/docs/latest/evolution/#schema-evolution" scope="external" format="html">
         schema evolution </xref> for more details.
       </p>
     </conbody>
@@ -362,7 +362,7 @@ CREATE TABLE ice_ctas_part_spec PARTITIONED BY SPEC (truncate(3, s)) STORED AS I
     <title>Partitioning Iceberg tables</title>
     <conbody>
       <p>
-        <xref href="https://iceberg.apache.org/#spec/%23partitioning" scope="external" format="html">
+        <xref href="https://iceberg.apache.org/docs/latest/partitioning/" scope="external" format="html">
         The Iceberg spec </xref> has information about partitioning Iceberg tables. With Iceberg,
         we are not limited to value-based partitioning, we can also partition our tables via
         several partition transforms.
@@ -379,7 +379,7 @@ STORED AS ICEBERG;
       </p>
       <p>
         Iceberg also supports
-        <xref href="https://iceberg.apache.org/#spec/%23partition-evolution" scope="external" format="html">
+        <xref href="https://iceberg.apache.org/docs/latest/evolution/#partition-evolution" scope="external" format="html">
         partition evolution</xref> which means that the partitioning of a table can be changed, even
         without the need of rewriting existing data files. You can change an existing table's
         partitioning via an <codeph>ALTER TABLE SET PARTITION SPEC</codeph> statement, e.g.:


[impala] 02/02: IMPALA-11208: Fix uninitialized counter of CollectionItemsRead in orc-scanner

Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 6ea15409b879a1286e72848defdda8d5d8568c19
Author: stiga-huang <hu...@gmail.com>
AuthorDate: Sat May 14 14:48:43 2022 +0800

    IMPALA-11208: Fix uninitialized counter of CollectionItemsRead in orc-scanner
    
    CollectionItemsRead in the runtime profile counts the total number of
    nested collection items read by the scan node. Only created for scans
    that support nested types, e.g. Parquet or ORC.
    
    Each scanner thread maintains its local counter and merges it into
    HdfsScanNode counter for each row batch. However, the local counter in
    orc-scanner is uninitialized, leading to weird values. This patch simply
    initializes it to 0 and adds test coverage.
    
    Tests:
    Add profile verification for this counter on some existing query tests.
    Note that there are some implementation difference between Parquet and
    ORC scanners (e.g. in predicate pushdown). So we will see different
    counter results in some query. I just pick some queries that have
    consistent counters.
    
    Change-Id: Id7783d1460ac9b98e94d3a31028b43f5a9884f99
    Reviewed-on: http://gerrit.cloudera.org:8080/18528
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/exec/hdfs-orc-scanner.h                                    | 2 +-
 .../QueryTest/nested-types-scanner-array-materialization.test     | 8 ++++++++
 .../functional-query/queries/QueryTest/nested-types-tpch.test     | 2 ++
 testdata/workloads/tpch/queries/tpch-q1.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q10.test                     | 2 ++
 testdata/workloads/tpch/queries/tpch-q11.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q12.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q13.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q14.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q15.test                     | 2 ++
 testdata/workloads/tpch/queries/tpch-q16.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q17.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q18.test                     | 2 ++
 testdata/workloads/tpch/queries/tpch-q19.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q2.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q20.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q21.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q22.test                     | 4 +++-
 testdata/workloads/tpch/queries/tpch-q3.test                      | 2 ++
 testdata/workloads/tpch/queries/tpch-q4.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q5.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q6.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q7.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q8.test                      | 4 +++-
 testdata/workloads/tpch/queries/tpch-q9.test                      | 4 +++-
 25 files changed, 73 insertions(+), 19 deletions(-)

diff --git a/be/src/exec/hdfs-orc-scanner.h b/be/src/exec/hdfs-orc-scanner.h
index 477f0b7b5..a446c1998 100644
--- a/be/src/exec/hdfs-orc-scanner.h
+++ b/be/src/exec/hdfs-orc-scanner.h
@@ -299,7 +299,7 @@ class HdfsOrcScanner : public HdfsColumnarScanner {
   /// used to reduce the frequency of updating HdfsScanNode counter. It is updated by the
   /// callees of AssembleRows() and is merged into the HdfsScanNode counter at the end of
   /// AssembleRows() and then is reset to 0.
-  int64_t coll_items_read_counter_;
+  int64_t coll_items_read_counter_ = 0;
 
   const char *filename() const { return metadata_range_->file(); }
 
diff --git a/testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-array-materialization.test b/testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-array-materialization.test
index bef001671..ef3ce090a 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-array-materialization.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-array-materialization.test
@@ -15,6 +15,10 @@ select id, a.item from complextypestbl t, t.int_array a
 8,-1
 ---- TYPES
 bigint,int
+---- RUNTIME_PROFILE
+row_regex: .*CollectionItemsRead: 5 \(5\).*
+row_regex: .*CollectionItemsRead: 1 \(1\).*
+row_regex: .*CollectionItemsRead: 9 \(9\).*
 ====
 ---- QUERY
 -- Materialize array (for now, may be optimized away someday)
@@ -32,6 +36,10 @@ NULL
 -1
 ---- TYPES
 int
+---- RUNTIME_PROFILE
+row_regex: .*CollectionItemsRead: 5 \(5\).*
+row_regex: .*CollectionItemsRead: 1 \(1\).*
+row_regex: .*CollectionItemsRead: 9 \(9\).*
 ====
 ---- QUERY
 -- Materialize scalar and array
diff --git a/testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch.test b/testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch.test
index dcfc1a980..26a5cf40c 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch.test
@@ -15,6 +15,8 @@ from customer c, c.c_orders o, o.o_lineitems i
 6001215
 ---- TYPES
 bigint
+---- RUNTIME_PROFILE
+row_regex: .*CollectionItemsRead: 2.50M \(2500405\).*
 ====
 ---- QUERY
 select count(l_linenumber)
diff --git a/testdata/workloads/tpch/queries/tpch-q1.test b/testdata/workloads/tpch/queries/tpch-q1.test
index 08cb7ccbd..94ed5034a 100644
--- a/testdata/workloads/tpch/queries/tpch-q1.test
+++ b/testdata/workloads/tpch/queries/tpch-q1.test
@@ -29,4 +29,6 @@ order by
 'R','F',37719753.00,56568041380.90,53741292684.6040,55889619119.831932,25.505794,38250.854626,0.050009,1478870
 ---- TYPES
 string, string, decimal, decimal, decimal, decimal, decimal, decimal, decimal, bigint
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q10.test b/testdata/workloads/tpch/queries/tpch-q10.test
index b87748733..2693d1889 100644
--- a/testdata/workloads/tpch/queries/tpch-q10.test
+++ b/testdata/workloads/tpch/queries/tpch-q10.test
@@ -59,4 +59,6 @@ limit 20
 23431,'Customer#000023431',554269.5360,3381.86,'ROMANIA','HgiV0phqhaIa9aydNoIlb','29-915-458-2654','nusual, even instructions: furiously stealthy n'
 ---- TYPES
 bigint, string, decimal, decimal, string, string, string, string
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
 ====
diff --git a/testdata/workloads/tpch/queries/tpch-q11.test b/testdata/workloads/tpch/queries/tpch-q11.test
index 7e87b6974..1d5bfc86e 100644
--- a/testdata/workloads/tpch/queries/tpch-q11.test
+++ b/testdata/workloads/tpch/queries/tpch-q11.test
@@ -1085,4 +1085,6 @@ order by
 5182,7874521.73
 ---- TYPES
 BIGINT, decimal
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q12.test b/testdata/workloads/tpch/queries/tpch-q12.test
index ce4080326..ca86c318f 100644
--- a/testdata/workloads/tpch/queries/tpch-q12.test
+++ b/testdata/workloads/tpch/queries/tpch-q12.test
@@ -34,4 +34,6 @@ order by
 'SHIP',6200,9262
 ---- TYPES
 string, bigint, bigint
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q13.test b/testdata/workloads/tpch/queries/tpch-q13.test
index d09613b4b..fc131fc70 100644
--- a/testdata/workloads/tpch/queries/tpch-q13.test
+++ b/testdata/workloads/tpch/queries/tpch-q13.test
@@ -66,4 +66,6 @@ order by
 39,1
 ---- TYPES
 BIGINT, BIGINT
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q14.test b/testdata/workloads/tpch/queries/tpch-q14.test
index 8fb41b4af..29417cc7e 100644
--- a/testdata/workloads/tpch/queries/tpch-q14.test
+++ b/testdata/workloads/tpch/queries/tpch-q14.test
@@ -18,4 +18,6 @@ where
 16.380779
 ---- TYPES
 decimal
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q15.test b/testdata/workloads/tpch/queries/tpch-q15.test
index 19c2909a8..b34624925 100644
--- a/testdata/workloads/tpch/queries/tpch-q15.test
+++ b/testdata/workloads/tpch/queries/tpch-q15.test
@@ -35,4 +35,6 @@ order by
 8449,'Supplier#000008449','Wp34zim9qYFbVctdW','20-469-856-8873',1772627.2087
 ---- TYPES
 BIGINT, STRING, STRING, STRING, DECIMAL
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
 ====
diff --git a/testdata/workloads/tpch/queries/tpch-q16.test b/testdata/workloads/tpch/queries/tpch-q16.test
index 20f65df55..0dda01260 100644
--- a/testdata/workloads/tpch/queries/tpch-q16.test
+++ b/testdata/workloads/tpch/queries/tpch-q16.test
@@ -18348,4 +18348,6 @@ order by
 'Brand#55','STANDARD PLATED TIN',49,3
 ---- TYPES
 STRING, STRING, INT, BIGINT
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q17.test b/testdata/workloads/tpch/queries/tpch-q17.test
index ab4a62ee8..dab9a0e09 100644
--- a/testdata/workloads/tpch/queries/tpch-q17.test
+++ b/testdata/workloads/tpch/queries/tpch-q17.test
@@ -22,4 +22,6 @@ where
 348406.054286
 ---- TYPES
 decimal
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q18.test b/testdata/workloads/tpch/queries/tpch-q18.test
index bdf74dac6..82629b910 100644
--- a/testdata/workloads/tpch/queries/tpch-q18.test
+++ b/testdata/workloads/tpch/queries/tpch-q18.test
@@ -97,4 +97,6 @@ limit 100
 'Customer#000088703',88703,2995076,'1994-01-30',363812.12,302.00
 ---- TYPES
 STRING, BIGINT, BIGINT, STRING, DECIMAL, DECIMAL
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
 ====
diff --git a/testdata/workloads/tpch/queries/tpch-q19.test b/testdata/workloads/tpch/queries/tpch-q19.test
index c342f215e..caac7a16d 100644
--- a/testdata/workloads/tpch/queries/tpch-q19.test
+++ b/testdata/workloads/tpch/queries/tpch-q19.test
@@ -40,4 +40,6 @@ where
 3083843.0578
 ---- TYPES
 decimal
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q2.test b/testdata/workloads/tpch/queries/tpch-q2.test
index 3f8f77d3f..7d40d48c1 100644
--- a/testdata/workloads/tpch/queries/tpch-q2.test
+++ b/testdata/workloads/tpch/queries/tpch-q2.test
@@ -148,4 +148,6 @@ limit 100
 7843.52,'Supplier#000006683','FRANCE',11680,'Manufacturer#4','2Z0JGkiv01Y00oCFwUGfviIbhzCdy','16-464-517-8943',' express, final pinto beans x-ray slyly asymptotes. unusual, unusual'
 ---- TYPES
 DECIMAL, STRING, STRING, BIGINT, STRING, STRING, STRING, STRING
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q20.test b/testdata/workloads/tpch/queries/tpch-q20.test
index 64568a359..69e699485 100644
--- a/testdata/workloads/tpch/queries/tpch-q20.test
+++ b/testdata/workloads/tpch/queries/tpch-q20.test
@@ -226,4 +226,6 @@ order by
 'Supplier#000009974','7wJ,J5DKcxSU4Kp1cQLpbcAvB5AsvKT'
 ---- TYPES
 string, string
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q21.test b/testdata/workloads/tpch/queries/tpch-q21.test
index 3fbadc495..486b33ee2 100644
--- a/testdata/workloads/tpch/queries/tpch-q21.test
+++ b/testdata/workloads/tpch/queries/tpch-q21.test
@@ -144,4 +144,6 @@ limit 100
 'Supplier#000002483',12
 ---- TYPES
 string, bigint
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q22.test b/testdata/workloads/tpch/queries/tpch-q22.test
index 1299ee160..93b00f016 100644
--- a/testdata/workloads/tpch/queries/tpch-q22.test
+++ b/testdata/workloads/tpch/queries/tpch-q22.test
@@ -45,4 +45,6 @@ order by
 '31',922,6806670.18
 ---- TYPES
 string, bigint, decimal
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q3.test b/testdata/workloads/tpch/queries/tpch-q3.test
index 9b57607d0..f9fc981d1 100644
--- a/testdata/workloads/tpch/queries/tpch-q3.test
+++ b/testdata/workloads/tpch/queries/tpch-q3.test
@@ -39,4 +39,6 @@ limit 10
 2300070,367371.1452,'1995-03-13',0
 ---- TYPES
 BIGINT, DECIMAL, STRING, INT
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
 ====
diff --git a/testdata/workloads/tpch/queries/tpch-q4.test b/testdata/workloads/tpch/queries/tpch-q4.test
index 00c3a87d5..69095bad7 100644
--- a/testdata/workloads/tpch/queries/tpch-q4.test
+++ b/testdata/workloads/tpch/queries/tpch-q4.test
@@ -30,4 +30,6 @@ order by
 '5-LOW',10487
 ---- TYPES
 string, bigint
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q5.test b/testdata/workloads/tpch/queries/tpch-q5.test
index d05d29a52..311c8690d 100644
--- a/testdata/workloads/tpch/queries/tpch-q5.test
+++ b/testdata/workloads/tpch/queries/tpch-q5.test
@@ -33,4 +33,6 @@ order by
 'JAPAN',45410175.6954
 ---- TYPES
 string, decimal
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q6.test b/testdata/workloads/tpch/queries/tpch-q6.test
index 1642d0e2f..a4cf082dc 100644
--- a/testdata/workloads/tpch/queries/tpch-q6.test
+++ b/testdata/workloads/tpch/queries/tpch-q6.test
@@ -14,4 +14,6 @@ where
 123141078.2283
 ---- TYPES
 decimal
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q7.test b/testdata/workloads/tpch/queries/tpch-q7.test
index 7c08522f4..e596743d6 100644
--- a/testdata/workloads/tpch/queries/tpch-q7.test
+++ b/testdata/workloads/tpch/queries/tpch-q7.test
@@ -46,4 +46,6 @@ order by
 'GERMANY','FRANCE',1996,52520549.0224
 ---- TYPES
 STRING, STRING, INT, DECIMAL
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q8.test b/testdata/workloads/tpch/queries/tpch-q8.test
index 01ed84386..54a53b415 100644
--- a/testdata/workloads/tpch/queries/tpch-q8.test
+++ b/testdata/workloads/tpch/queries/tpch-q8.test
@@ -43,4 +43,6 @@ order by
 1996,0.041486
 ---- TYPES
 int, decimal
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====
diff --git a/testdata/workloads/tpch/queries/tpch-q9.test b/testdata/workloads/tpch/queries/tpch-q9.test
index 78981da0c..8b45bdad5 100644
--- a/testdata/workloads/tpch/queries/tpch-q9.test
+++ b/testdata/workloads/tpch/queries/tpch-q9.test
@@ -210,4 +210,6 @@ order by
 'VIETNAM',1992,47846355.6485
 ---- TYPES
 STRING, INT, DECIMAL
-====
\ No newline at end of file
+---- RUNTIME_PROFILE
+!row_regex: .*CollectionItemsRead: [^0].*
+====