[GitHub] [spark] rdblue commented on a change in pull request #25569: [SPARK-28863][SQL] Introduce AlreadyPlanned, a node that speeds-up planning

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #25569: [SPARK-28863][SQL] Introduce AlreadyPlanned, a node that speeds-up planning
URL: https://github.com/apache/spark/pull/25569#discussion_r317337735
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
 ##########
 @@ -632,6 +632,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
 
   object BasicOperators extends Strategy {
     def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
+      case AlreadyPlanned(physical, output) => AlreadyPlannedExec(physical, output) :: Nil
 
 Review comment:
   I don't think that we want to rewrite expression IDs. This should only be used for cases where we need to pass a physical plan as a logical plan within the same physical plan's execution. That's the case for `InsertableRelation`. We want all of those physical nodes to remain unchanged so that metrics are correctly reported to the UI.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org