[GitHub] [hbase] Apache9 commented on a change in pull request #3374: HBASE-25980 Master table.jsp pointed at meta throws 500 when no all r…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #3374:
URL: https://github.com/apache/hbase/pull/3374#discussion_r650053036



##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -313,7 +314,12 @@
           for (int j = 0; j < numMetaReplicas; j++) {
             RegionInfo meta = RegionReplicaUtil.getRegionInfoForReplica(
                                     RegionInfoBuilder.FIRST_META_REGIONINFO, j);
-            ServerName metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+            ServerName metaLocation = null;
+            try {
+              metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+            } catch (NotAllMetaRegionsOnlineException e) {
+              //Should ignore this Exception for we don't need to display rit meta region info in UI

Review comment:
       Should ignore this Exception for we don't need to display rit meta region info in UI
   =>
   Should ignore this Exception as we don't need to display rit meta region info in UI
   
   Use 'as' instead of 'for'.
   
   And mind explaining a bit more on why we do not need to dispay rit meta region info? And what is going on if metaLocation is null?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org