You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbertram (via GitHub)" <gi...@apache.org> on 2023/04/27 21:13:17 UTC

[GitHub] [activemq-artemis] jbertram commented on pull request #4458: [ARTEMIS-4263] - authenticator to adapt to artemis jaas login modules…

jbertram commented on PR #4458:
URL: https://github.com/apache/activemq-artemis/pull/4458#issuecomment-1526484809

   What's the use-case for this?
   
   Also, you can omit the square brackets and dash from your commit message so that it's just:
   ```
   ARTEMIS-4263 authenticator to adapt to artemis jaas login modules callback handler
   ```
   IMO it makes it easier to read and follows the pattern from the [hacking guide](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/en/code.md#commitMessageDetails).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org