[jira] [Resolved] (NET-538) FTPHTTPClient should use socket factory to create sockets

["Sebb (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NET-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-538.
----------------------
       Resolution: Fixed
    Fix Version/s: 3.4

URL: http://svn.apache.org/r1683528
Log:
NET-538 - FTPHTTPClient should use socket factory to create sockets

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPHTTPClient.java


> FTPHTTPClient should use socket factory to create sockets
> ---------------------------------------------------------
>
>                 Key: NET-538
>                 URL: https://issues.apache.org/jira/browse/NET-538
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.3
>         Environment: win7 + java 64, apache-commons-net3.3.jar
>            Reporter: Dzmitry
>            Priority: Minor
>             Fix For: 3.4
>
>
> FTPHTTPClient can't set socket timeout when connecting to remote http proxy. This may cause hangouts for calls to remote http ftp proxies.
> Expected: FTPHTTPClient  supports creation sockets with Factory methods. We had same approach for regular FTPClient calling .setSocketFactory(...) method and have control over socket creation.
> Actual: FTPHTTPClient  creates Socket inside public void connect(...) directly, and it is impossible to set timouts since this object will be used immediately. It is even impossible to inherit from FTPHTTPClient   to override connect - since proxyHost, proxyPort and tunnelHandshake is private.
> so we may change 
>       _socket_ = new Socket(proxyHost, proxyPort);
> to 
>      _socket_ = _socketFactory_.createSocket();
> and add support for FTPHTTPClient  to handle socket factories for http proxies calls.
> Is it possiible?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)