You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/12/29 14:35:55 UTC

[GitHub] [incubator-echarts] Nick22nd opened a new pull request #13902: fix(Calendar): fix day label drifting. close #11508

Nick22nd opened a new pull request #13902:
URL: https://github.com/apache/incubator-echarts/pull/13902


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   fix day label drifting
   
   
   
   ### Fixed issues
   
   
   - #11508: Day label is drifting on the left when calendar range is getting smaller
   
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   If orient is horizontal and range changes, the cell will automatically adjust its width.
   But the weekly text margin always to be 50% width of cellSize.
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   ![issue](https://user-images.githubusercontent.com/30228906/103290962-b1abbe00-4a25-11eb-9a64-e9d5feb10858.PNG)
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   I tried to fix it by making daylabel margin always be the cell's height .
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   ![fixed](https://user-images.githubusercontent.com/30228906/103291125-0a7b5680-4a26-11eb-959b-a74472162145.PNG)
   
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13902: fix(Calendar): fix day label drifting. close #11508

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13902:
URL: https://github.com/apache/incubator-echarts/pull/13902#issuecomment-752099430


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org