[jira] [Comment Edited] (IGNITE-3138) IgniteDataStreamer: failures are not shown on the streaming side

["Vladislav Pyatkov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419054#comment-15419054 ] 

Vladislav Pyatkov edited comment on IGNITE-3138 at 8/12/16 4:00 PM:
--------------------------------------------------------------------

Than [~dmagda], I looked at you review and adding some changes.
I disagree doing {{f.get}} from {{future}} before the invoke {{flash}} buffer.
Because this lead to hanging on some Futures (which stay at buffer).
After flush buffer was invoked, this can be do (see at the end of cycle).


was (Author: v.pyatkov):
Than Dennis, I looked at you review and adding some changes.
I disagree doing {{f.get}} from {{future}} before the invoke {{flash}} buffer.
Because this lead to hanging on some Futures (which stay at buffer).
After flush buffer was invoked, this can be do (see at the end of cycle).

> IgniteDataStreamer: failures are not shown on the streaming side
> ----------------------------------------------------------------
>
>                 Key: IGNITE-3138
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3138
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Denis Magda
>            Assignee: Vladislav Pyatkov
>         Attachments: DataStreamerFailuresTest.java
>
>
> If an exception happens during the streaming, the side that streams the data won't printed out anything in its logs even if IGNITE_QUIET set to false.
> This makes it's inconvenient to see whether there an issue happened during the streaming or not.
> Suggested improvements:
> - print out errors that happened during the streaming on the streaming side;
> - Future that is returned from {{addData}} methods is not called in case of error. This must be fixed. So that the user is able to write a custom logic around this feature and process errors somehow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)