You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/21 18:37:43 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #570: Fix #560
AHC extension
ppalaga opened a new pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #570:
Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360667271
##########
File path: pom.xml
##########
@@ -40,9 +40,11 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <ahc.version>2.10.4</ahc.version>
Review comment:
Actually not for this PR directly, but it will be needed for the Telegram extension that needs AHC but has nothing to do with camel-ahc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #570: Fix #560 AHC
extension
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#issuecomment-568300845
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/502/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #570:
Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360667302
##########
File path: poms/bom-deployment/pom.xml
##########
@@ -35,7 +35,6 @@
<properties>
<camel-quarkus.version>1.1.0-SNAPSHOT</camel-quarkus.version><!-- kept in sync with project.version by the release plugin -->
- <jandex-maven-plugin.version>1.0.6</jandex-maven-plugin.version>
Review comment:
Uneeded indeed. Let me remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#570: Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360662401
##########
File path: extensions/ahc/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus HTTP Common"
+description: "Camel Quarkus HTTP Common"
Review comment:
looks like the name and description are wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #570:
Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360667302
##########
File path: poms/bom-deployment/pom.xml
##########
@@ -35,7 +35,6 @@
<properties>
<camel-quarkus.version>1.1.0-SNAPSHOT</camel-quarkus.version><!-- kept in sync with project.version by the release plugin -->
- <jandex-maven-plugin.version>1.0.6</jandex-maven-plugin.version>
Review comment:
Unrelated indeed. Let me isolate it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #570: Fix #560 AHC
extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#issuecomment-568261144
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #570: Fix #560 AHC
extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#issuecomment-568456795
88998b2 rebased and fixed conflicts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#570: Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360662751
##########
File path: poms/bom-deployment/pom.xml
##########
@@ -35,7 +35,6 @@
<properties>
<camel-quarkus.version>1.1.0-SNAPSHOT</camel-quarkus.version><!-- kept in sync with project.version by the release plugin -->
- <jandex-maven-plugin.version>1.0.6</jandex-maven-plugin.version>
Review comment:
this jandex thing seems unrelated to the pr, can we make this change in a separate commit ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#570: Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360662698
##########
File path: pom.xml
##########
@@ -40,9 +40,11 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <ahc.version>2.10.4</ahc.version>
Review comment:
do we need this version or can we inherit from camel-ahc ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#570: Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360667383
##########
File path: pom.xml
##########
@@ -40,9 +40,11 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <ahc.version>2.10.4</ahc.version>
Review comment:
yeah but this add some maintenance cost as we need to be sure this is in sync with the version used by camel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #570: Fix #560 AHC
extension
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#issuecomment-568252692
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/497/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-hystrix' /><a href='https://builds.apache.org/job/camel-quarkus-pr/497/org.apache.camel.quarkus$camel-quarkus-integration-test-hystrix/testReport'>camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-hystrix</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/camel-quarkus-pr/497/org.apache.camel.quarkus$camel-quarkus-integration-test-hystrix/testReport/org.apache.camel.quarkus.component.hystrix.it/HystrixTest/testHystrixFallback/'><strong>org.apache.camel.quarkus.component.hystrix.it.HystrixTest.testHystrixFallback</strong></a></li></ul>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] davsclaus commented on issue #570: Fix #560 AHC
extension
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#issuecomment-568240467
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #570: Fix #560 AHC
extension
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#570: Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360662427
##########
File path: extensions/pom.xml
##########
@@ -100,6 +100,7 @@
<module>vm</module>
<module>xslt</module>
<module>zipfile</module>
+ <module>ahc</module>
Review comment:
nor ordered
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #570:
Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360667071
##########
File path: extensions/ahc/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus HTTP Common"
+description: "Camel Quarkus HTTP Common"
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #570:
Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360667814
##########
File path: pom.xml
##########
@@ -40,9 +40,11 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <ahc.version>2.10.4</ahc.version>
Review comment:
Yes, that could be mitigated by
(a) Importing the Camel BoM, or
(b) Enabling the Dependency Convergence Rule on the Maven Enforcer plugin or
(c) A groovy script :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #570: Fix #560 AHC
extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#issuecomment-568211158
Luca's requests addressed in 58ca689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #570:
Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360667157
##########
File path: extensions/pom.xml
##########
@@ -100,6 +100,7 @@
<module>vm</module>
<module>xslt</module>
<module>zipfile</module>
+ <module>ahc</module>
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#570: Fix #560 AHC extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #570: Fix #560 AHC extension
URL: https://github.com/apache/camel-quarkus/pull/570#discussion_r360695073
##########
File path: pom.xml
##########
@@ -40,9 +40,11 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <ahc.version>2.10.4</ahc.version>
Review comment:
I think we really need to consider option 1, eventually we may need to clean up a bit the camel's bom but I think that as long term we'll end up supporting most of the component camel supports and the chance to hit this issue again is in my opinion high
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services