You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2016/03/02 00:32:07 UTC

[GitHub] spark pull request: [SPARK-11826][MLlib] Refactor add() and subtra...

Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/9916#issuecomment-190965496
  
    @ehsanmok Sorry for the delay.  Could you please add a to-do in the code for using zero matrices more efficiently?  Other than that, it looks fine.
    
    Would you be interested in submitting a PR to Breeze to add a primitive for subtracting a DenseMatrix and CSCMatrix?  If you can, please CC me on the PR, and I can help review it.  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org