You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bb...@apache.org on 2023/03/31 13:47:06 UTC
[hbase] branch branch-2.5 updated: HBASE-27758 Inconsistent synchronization in MetricsUserSourceImpl (#5149)
This is an automated email from the ASF dual-hosted git repository.
bbeaudreault pushed a commit to branch branch-2.5
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.5 by this push:
new 694752b781f HBASE-27758 Inconsistent synchronization in MetricsUserSourceImpl (#5149)
694752b781f is described below
commit 694752b781f7d6b069c0a44cafc3ecf5f05652fc
Author: Bryan Beaudreault <bb...@apache.org>
AuthorDate: Fri Mar 31 08:10:58 2023 -0400
HBASE-27758 Inconsistent synchronization in MetricsUserSourceImpl (#5149)
Signed-off-by: Duo Zhang <zh...@apache.org>
---
.../hbase/regionserver/MetricsUserSourceImpl.java | 32 ++++++++++------------
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserSourceImpl.java b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserSourceImpl.java
index 95cb3623954..cae26244b7b 100644
--- a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserSourceImpl.java
+++ b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserSourceImpl.java
@@ -133,15 +133,13 @@ public class MetricsUserSourceImpl implements MetricsUserSource {
@Override
public void register() {
- synchronized (this) {
- getHisto = registry.newTimeHistogram(userGetKey);
- scanTimeHisto = registry.newTimeHistogram(userScanTimeKey);
- putHisto = registry.newTimeHistogram(userPutKey);
- deleteHisto = registry.newTimeHistogram(userDeleteKey);
- incrementHisto = registry.newTimeHistogram(userIncrementKey);
- appendHisto = registry.newTimeHistogram(userAppendKey);
- replayHisto = registry.newTimeHistogram(userReplayKey);
- }
+ getHisto = registry.newTimeHistogram(userGetKey);
+ scanTimeHisto = registry.newTimeHistogram(userScanTimeKey);
+ putHisto = registry.newTimeHistogram(userPutKey);
+ deleteHisto = registry.newTimeHistogram(userDeleteKey);
+ incrementHisto = registry.newTimeHistogram(userIncrementKey);
+ appendHisto = registry.newTimeHistogram(userAppendKey);
+ replayHisto = registry.newTimeHistogram(userReplayKey);
}
@Override
@@ -157,15 +155,13 @@ public class MetricsUserSourceImpl implements MetricsUserSource {
LOG.debug("Removing user Metrics for user: " + user);
}
- synchronized (this) {
- registry.removeMetric(userGetKey);
- registry.removeMetric(userScanTimeKey);
- registry.removeMetric(userPutKey);
- registry.removeMetric(userDeleteKey);
- registry.removeMetric(userIncrementKey);
- registry.removeMetric(userAppendKey);
- registry.removeMetric(userReplayKey);
- }
+ registry.removeMetric(userGetKey);
+ registry.removeMetric(userScanTimeKey);
+ registry.removeMetric(userPutKey);
+ registry.removeMetric(userDeleteKey);
+ registry.removeMetric(userIncrementKey);
+ registry.removeMetric(userAppendKey);
+ registry.removeMetric(userReplayKey);
}
@Override