You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/12 22:54:10 UTC
Review Request 55476: Changed TASK_UNREACHABLE to be a non-terminal
state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55476/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
This task state was always conceptually non-terminal, but previously
`isTerminalState` returned true for it. Now that the master
distinguishes between "removable" and "terminal" task states, we can
correctly classify TASK_UNREACHABLE as a removal but non-terminal task
state.
Diffs
-----
src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
Diff: https://reviews.apache.org/r/55476/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 55476: Changed TASK_UNREACHABLE to be a
non-terminal state.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55476/#review162735
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 18, 2017, 7:33 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55476/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 7:33 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This task state was always conceptually non-terminal, but previously
> `isTerminalState` returned true for it. The master now distinguishes
> between "removable" and "terminal" task states, so we can correctly
> classify TASK_UNREACHABLE as a removable but non-terminal task state.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
>
> Diff: https://reviews.apache.org/r/55476/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55476: Changed TASK_UNREACHABLE to be a
non-terminal state.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55476/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 7:33 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Tweak commit message.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description (updated)
-------
This task state was always conceptually non-terminal, but previously
`isTerminalState` returned true for it. The master now distinguishes
between "removable" and "terminal" task states, so we can correctly
classify TASK_UNREACHABLE as a removable but non-terminal task state.
Diffs (updated)
-----
src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
Diff: https://reviews.apache.org/r/55476/diff/
Testing
-------
`make check`
Thanks,
Neil Conway