(caldera) branch fix/asf-yaml-discussions-and-protection created (now 58d1bddf)

[mp...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

deacon-mp pushed a change to branch fix/asf-yaml-discussions-and-protection
in repository https://gitbox.apache.org/repos/asf/caldera.git


      at 58d1bddf fix(.asf.yaml): add discussions notification target; use real check names in branch protection

This branch includes the following new commits:

     new 58d1bddf fix(.asf.yaml): add discussions notification target; use real check names in branch protection

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(caldera) 01/01: fix(.asf.yaml): add discussions notification target; use real check names in branch protection

[mp...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

deacon-mp pushed a commit to branch fix/asf-yaml-discussions-and-protection
in repository https://gitbox.apache.org/repos/asf/caldera.git

commit 58d1bddf98a7fc0b1946f2abf340cedf9201bea7
Author: deacon-mp <mp...@mitre.org>
AuthorDate: Thu Jul 23 20:16:34 2026 -0400

    fix(.asf.yaml): add discussions notification target; use real check names in branch protection
    
    ASF Infra rejects the github feature block with 'GitHub discussions can
    only be enabled if a mailing list target exists for it' — features.discussions
    requires a notifications.discussions target. Route it to dev@, alongside
    issues and pullrequests.
    
    Because that error aborted the whole github block, protected_branches has
    never actually applied. Its required_status_checks contexts named workflows
    (Code Quality, Security Checks) rather than check runs, which would never be
    reported and would wedge every merge once active. Replace them with the six
    real job names as recorded on GitHub check runs. Review requirement (1
    approving review, stale-review dismissal) and strict up-to-date checks now
    take effect deliberately.
---
 .asf.yaml | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/.asf.yaml b/.asf.yaml
index fe7b5878..1d35a6ed 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -12,6 +12,7 @@ notifications:
   commits:      commits@caldera.apache.org
   issues:       dev@caldera.apache.org
   pullrequests: dev@caldera.apache.org
+  discussions:  dev@caldera.apache.org   # required for github.features.discussions to be enabled
   # jobs: dev@caldera.apache.org        # GitHub Actions build status — enable if the project wants CI failures on-list
   # jira_options: link label comment    # only if Caldera adopts ASF Jira; it uses GitHub Issues, so omitted
   
@@ -49,7 +50,7 @@ github:
   dependabot_alerts: true
   dependabot_updates: false
 
-  # --- OPTIONAL self-serve branch protection (enable once the project agrees on required checks) ----
+  # --- Branch protection: 1 approving review + green CI required to merge to master -----------------
   protected_branches:
      master:
        required_pull_request_reviews:
@@ -57,9 +58,14 @@ github:
          dismiss_stale_reviews: true
        required_status_checks:
          strict: true
+         # Contexts must be check-run (job) names as reported to GitHub, not workflow names.
          contexts:
-           - Code Quality
-           - Security Checks
+           - "build (3.10.9, py310,style,coverage-ci)"
+           - "build (3.11, py311,style,coverage-ci)"
+           - "build (3.12, py312,style,coverage-ci)"
+           - "build (3.13, py313,style,coverage-ci)"
+           - "build (3.13, safety)"
+           - "build (3.13, bandit)"
        required_conversation_resolution: true
   #     # required_signatures: true    # only if all committers sign commits — can block merges otherwise
   copilot_code_review: