You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2019/01/03 02:33:57 UTC

[GitHub] chaoyli commented on a change in pull request #492: Modify segment file name

chaoyli commented on a change in pull request #492: Modify segment file name
URL: https://github.com/apache/incubator-doris/pull/492#discussion_r244903665
 
 

 ##########
 File path: be/src/olap/rowset/segment_reader.cpp
 ##########
 @@ -39,7 +39,6 @@ SegmentReader::SegmentReader(
         const std::vector<uint32_t>& used_columns,
         const std::set<uint32_t>& load_bf_columns,
         const Conditions* conditions,
-        const std::vector<ColumnPredicate*>* col_predicates,
 
 Review comment:
   You should make you initialization order in accordance with variable declaration order in header file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org