You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mike Mansell (JIRA)" <ji...@codehaus.org> on 2010/02/17 22:05:55 UTC
[jira] Created: (MASSEMBLY-470) skipAssembly doesn't work for
directory based mojos
skipAssembly doesn't work for directory based mojos
---------------------------------------------------
Key: MASSEMBLY-470
URL: http://jira.codehaus.org/browse/MASSEMBLY-470
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Affects Versions: 2.2-beta-5
Reporter: Mike Mansell
Attachments: skipAssembly-directory.patch
The skipAssembly property is only used within the execute method of the AbstractAssemblyMojo. However, the AbstractDirectoryMojo overrides (and doesn't call) the execute. Unfortunately, this overridden execute doesn't respect the skipAssembly variable. Therefore, the directory based mojos (directory-inline, directory and directory-single) can't be skipped.
This is a simple fix and the patch is included.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-470) skipAssembly doesn't work for
directory based mojos
Posted by "Vincent Latombe (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=220644#action_220644 ]
Vincent Latombe commented on MASSEMBLY-470:
-------------------------------------------
Just bumped into this bug. It is pretty annoying.
> skipAssembly doesn't work for directory based mojos
> ---------------------------------------------------
>
> Key: MASSEMBLY-470
> URL: http://jira.codehaus.org/browse/MASSEMBLY-470
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-5
> Reporter: Mike Mansell
> Attachments: skipAssembly-directory.patch
>
>
> The skipAssembly property is only used within the execute method of the AbstractAssemblyMojo. However, the AbstractDirectoryMojo overrides (and doesn't call) the execute. Unfortunately, this overridden execute doesn't respect the skipAssembly variable. Therefore, the directory based mojos (directory-inline, directory and directory-single) can't be skipped.
> This is a simple fix and the patch is included.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-470) skipAssembly doesn't work for
directory based mojos
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MASSEMBLY-470.
--------------------------------
Resolution: Won't Fix
Fix Version/s: 2.2-beta-6
Assignee: John Casey
all mojos except assembly:single are going to be deprecated as of 2.2-beta-6, since the single goal can handle the functions of all others except assembly:unpack...which has a replacement in the dependency plugin.
Please use an assembly with <format>dir</format> to produce a directory assembly using the single mojo.
> skipAssembly doesn't work for directory based mojos
> ---------------------------------------------------
>
> Key: MASSEMBLY-470
> URL: http://jira.codehaus.org/browse/MASSEMBLY-470
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-5
> Reporter: Mike Mansell
> Assignee: John Casey
> Fix For: 2.2-beta-6
>
> Attachments: skipAssembly-directory.patch
>
>
> The skipAssembly property is only used within the execute method of the AbstractAssemblyMojo. However, the AbstractDirectoryMojo overrides (and doesn't call) the execute. Unfortunately, this overridden execute doesn't respect the skipAssembly variable. Therefore, the directory based mojos (directory-inline, directory and directory-single) can't be skipped.
> This is a simple fix and the patch is included.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-470) skipAssembly doesn't work for
directory based mojos
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MASSEMBLY-470:
--------------------------------------
Fix Version/s: (was: 2.2)
> skipAssembly doesn't work for directory based mojos
> ---------------------------------------------------
>
> Key: MASSEMBLY-470
> URL: http://jira.codehaus.org/browse/MASSEMBLY-470
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-5
> Reporter: Mike Mansell
> Assignee: John Casey
> Attachments: skipAssembly-directory.patch
>
>
> The skipAssembly property is only used within the execute method of the AbstractAssemblyMojo. However, the AbstractDirectoryMojo overrides (and doesn't call) the execute. Unfortunately, this overridden execute doesn't respect the skipAssembly variable. Therefore, the directory based mojos (directory-inline, directory and directory-single) can't be skipped.
> This is a simple fix and the patch is included.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-470) skipAssembly doesn't work for
directory based mojos
Posted by "Gordon McNair (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230940#action_230940 ]
Gordon McNair commented on MASSEMBLY-470:
-----------------------------------------
We've run into this as well. We have the assembly bound to the package goal so that we can use deploy to publish assembly artifacts up to an Archiva repository. But this means when we run a job to do site-deploy and sonar it fails as it tries to build the assembly when the jars etc are renamed by clover. Using "-DskipAssembly=true" would be ideal but it won't work at the moment for us.
> skipAssembly doesn't work for directory based mojos
> ---------------------------------------------------
>
> Key: MASSEMBLY-470
> URL: http://jira.codehaus.org/browse/MASSEMBLY-470
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-5
> Reporter: Mike Mansell
> Attachments: skipAssembly-directory.patch
>
>
> The skipAssembly property is only used within the execute method of the AbstractAssemblyMojo. However, the AbstractDirectoryMojo overrides (and doesn't call) the execute. Unfortunately, this overridden execute doesn't respect the skipAssembly variable. Therefore, the directory based mojos (directory-inline, directory and directory-single) can't be skipped.
> This is a simple fix and the patch is included.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-470) skipAssembly doesn't work for
directory based mojos
Posted by "Gordon McNair (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230941#action_230941 ]
Gordon McNair commented on MASSEMBLY-470:
-----------------------------------------
Just tested by winding dependency back to use 2.2.-beta-4 and it worked as expected. So this appears to be an error introduced in 2.2-beta-5
> skipAssembly doesn't work for directory based mojos
> ---------------------------------------------------
>
> Key: MASSEMBLY-470
> URL: http://jira.codehaus.org/browse/MASSEMBLY-470
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-5
> Reporter: Mike Mansell
> Attachments: skipAssembly-directory.patch
>
>
> The skipAssembly property is only used within the execute method of the AbstractAssemblyMojo. However, the AbstractDirectoryMojo overrides (and doesn't call) the execute. Unfortunately, this overridden execute doesn't respect the skipAssembly variable. Therefore, the directory based mojos (directory-inline, directory and directory-single) can't be skipped.
> This is a simple fix and the patch is included.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira