You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/01/10 01:02:50 UTC
[kudu-CR] [examples] fix name of the class for spark-submit
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12206
Change subject: [examples] fix name of the class for spark-submit
......................................................................
[examples] fix name of the class for spark-submit
I also removed the redundant default port numbers for masters.
Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
---
M examples/scala/spark-example/README.adoc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/12206/1
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 )
Change subject: [examples] fix name of the class for spark-submit
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12206/1/examples/scala/spark-example/README.adoc
File examples/scala/spark-example/README.adoc:
http://gerrit.cloudera.org:8080/#/c/12206/1/examples/scala/spark-example/README.adoc@59
PS1, Line 59: master1
> Should we put 'master1:port' to be more clear here?
I think at line 45 there is information about that, but I agree it's better to clarify on that.
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jan 2019 02:58:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 )
Change subject: [examples] fix name of the class for spark-submit
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12206/2/examples/scala/spark-example/README.adoc
File examples/scala/spark-example/README.adoc:
http://gerrit.cloudera.org:8080/#/c/12206/2/examples/scala/spark-example/README.adoc@61
PS2, Line 61: '-DkuduMasters=master1,master2,master3 -DtableName=test_table' \
> nit: should this be at the same indentation level as all the other params?
This was intentional: this line continues the previous one, where each line is for specifying a flag key and value (so that's a continuation of continuation, that's why double indent).
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jan 2019 18:33:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 )
Change subject: [examples] fix name of the class for spark-submit
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12206/2/examples/scala/spark-example/README.adoc
File examples/scala/spark-example/README.adoc:
http://gerrit.cloudera.org:8080/#/c/12206/2/examples/scala/spark-example/README.adoc@61
PS2, Line 61: '-DkuduMasters=master1,master2,master3 -DtableName=test_table' \
nit: should this be at the same indentation level as all the other params?
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jan 2019 03:57:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 )
Change subject: [examples] fix name of the class for spark-submit
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jan 2019 21:27:02 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12206
to look at the new patch set (#2).
Change subject: [examples] fix name of the class for spark-submit
......................................................................
[examples] fix name of the class for spark-submit
I also updated the description of master RPC endpoints and
removed the redundant default port number for masters' RPC
endpoints in the example.
Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
---
M examples/scala/spark-example/README.adoc
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/12206/2
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 )
Change subject: [examples] fix name of the class for spark-submit
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12206/1/examples/scala/spark-example/README.adoc
File examples/scala/spark-example/README.adoc:
http://gerrit.cloudera.org:8080/#/c/12206/1/examples/scala/spark-example/README.adoc@59
PS1, Line 59: master1
Should we put 'master1:port' to be more clear here?
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jan 2019 01:10:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 )
Change subject: [examples] fix name of the class for spark-submit
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jan 2019 01:05:17 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 )
Change subject: [examples] fix name of the class for spark-submit
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jan 2019 03:58:00 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] fix name of the class for spark-submit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12206 )
Change subject: [examples] fix name of the class for spark-submit
......................................................................
[examples] fix name of the class for spark-submit
I also updated the description of master RPC endpoints and
removed the redundant default port number for masters' RPC
endpoints in the example.
Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Reviewed-on: http://gerrit.cloudera.org:8080/12206
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M examples/scala/spark-example/README.adoc
1 file changed, 11 insertions(+), 7 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, but someone else must approve
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic36a6fb62bd55667ea9f11c0124b5388f0e5bc7b
Gerrit-Change-Number: 12206
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)