You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2003/08/23 17:09:17 UTC
Re: [PATCH] Unifying and fixing the error handling for
ra_local and svnserve
On Sat, 2003-08-23 at 05:49, Tobias Ringström wrote:
> > Your diff against serve.c looks like it's against a slightly old version
> > of that file.
> > The second line should line up with the svn_path_join. (There are other
> > examples of this problem.)
Whoops, that was my MUA using a proportional font. Sorry for the
mix-up; these fancy new mail programs frighten and confuse me. (There
really was some bad second-line indentation in an older rev of serve.c,
which I thought might have misled you, and it was fixed by one of the
other developers in a recent checkin. But in fact, that had no bearing
on what I was seeing.)
The revised patch looks good. If no one else gets to it (and they
should feel free), I will try to apply it, sanity-check it, and check it
in today or tomorrow.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Unifying and fixing the error handling for ra_local and
svnserve
Posted by Tobias Ringström <to...@ringstrom.mine.nu>.
Greg Hudson wrote:
> Whoops, that was my MUA using a proportional font. Sorry for the
> mix-up; these fancy new mail programs frighten and confuse me. (There
> really was some bad second-line indentation in an older rev of serve.c,
> which I thought might have misled you, and it was fixed by one of the
> other developers in a recent checkin. But in fact, that had no bearing
> on what I was seeing.)
Ah - that explains it. I see that you are using Ximian Evolution. I
wonder why it changes spaces into tabs in the subject line. Seems like a
scary MUA indeed... :-)
> The revised patch looks good. If no one else gets to it (and they
> should feel free), I will try to apply it, sanity-check it, and check it
> in today or tomorrow.
Thanks a lot!
/Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Unifying and fixing the error handling for ra_local
and svnserve
Posted by Greg Hudson <gh...@MIT.EDU>.
On Sat, 2003-08-23 at 14:34, Tobias Ringström wrote:
> False alarm. It turned out to be your change to config_file.c in r6839
> that caused the failures. ;-) Updating to r6840 makes all tests pass again.
Oof. That's what I get for not runing "make check" because "it's just a
doc fix." Thanks for fixing that, David.
Your patch is committed.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Unifying and fixing the error handling for ra_local and
svnserve
Posted by Tobias Ringström <to...@ringstrom.mine.nu>.
Tobias Ringström wrote:
> Greg Hudson wrote:
>
>> The revised patch looks good. If no one else gets to it (and they
>> should feel free), I will try to apply it, sanity-check it, and check it
>> in today or tomorrow.
>
> Whops. I got failures when running "make check" with the revised patch.
> I'll investigate and get back ASAP.
False alarm. It turned out to be your change to config_file.c in r6839
that caused the failures. ;-) Updating to r6840 makes all tests pass again.
/Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Unifying and fixing the error handling for ra_local and
svnserve
Posted by Tobias Ringström <to...@ringstrom.mine.nu>.
Greg Hudson wrote:
> The revised patch looks good. If no one else gets to it (and they
> should feel free), I will try to apply it, sanity-check it, and check it
> in today or tomorrow.
Whops. I got failures when running "make check" with the revised patch.
I'll investigate and get back ASAP.
/Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org