You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "JC (JIRA)" <ji...@apache.org> on 2017/03/31 20:28:42 UTC
[jira] [Created] (HBASE-17862) Condition that always returns true
JC created HBASE-17862:
--------------------------
Summary: Condition that always returns true
Key: HBASE-17862
URL: https://issues.apache.org/jira/browse/HBASE-17862
Project: HBase
Issue Type: Bug
Components: Client
Reporter: JC
Priority: Trivial
Hi
In recent github mirror of hbase, I've found the following code smell.
Path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
{code}
209
210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
211 if (this.columnOffset != null) {
212 return this.getLimit() == this.getLimit() &&
213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
214 }
{code}
It should be?
{code}
212 return this.getLimit() == other.getLimit() &&
{code}
This might be just a code smell as Bytes.equals can be enough for the return value but wanted to report just in case.
Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)