[GitHub] [ozone] sodonnel commented on a change in pull request #3026: HDDS-6237: EC: putBlock should pass close flag true on end of block group/close file.

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #3026:
URL: https://github.com/apache/ozone/pull/3026#discussion_r795595348



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestECKeyOutputStream.java
##########
@@ -229,6 +237,40 @@ public void testMultipleChunksInSingleWriteOp(int numChunks)
     validateContent(inputData, bucket, bucket.getKey(keyName));
   }
 
+  @Test

Review comment:
       I have a question on this - is the container key count only incremented when the block is closed via sending the close flag? Is that why this test is checking the key count increases after writing a key?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org