You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2023/12/08 23:40:59 UTC
[PR] HDDS-9365. [hsync] DataNode to deserialize Ratis transaction only once. [ozone]
szetszwo opened a new pull request, #5752:
URL: https://github.com/apache/ozone/pull/5752
## What changes were proposed in this pull request?
Today DataNode deserializes request proto at every callback method: applyTransaction, applyTransaction, writeTransaction, readTransaction.
For a transaction, the deserialzation happens more than 5 times (readTransaction happens twice for leader)
It's super expensive. We should deserialize only once during preAppendTransaction() which takes place in parallel.
## What is the link to the Apache JIRA
HDDS-9365
## How was this patch tested?
Existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9365. [hsync] DataNode to deserialize Ratis transaction only once. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #5752:
URL: https://github.com/apache/ozone/pull/5752#issuecomment-1852604083
@jojochuang , it can pass the tests now. Please take a look again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9365. [hsync] DataNode to deserialize Ratis transaction only once. [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #5752:
URL: https://github.com/apache/ozone/pull/5752#issuecomment-1850753394
Looks like the PR fails the acceptance tests consecutively. @szetszwo can you check again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9365. [hsync] DataNode to deserialize Ratis transaction only once. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #5752:
URL: https://github.com/apache/ozone/pull/5752#issuecomment-1851219010
The test failures were due to the context is not created in follower. Just have updated the code to see if it can pass the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9365. [hsync] DataNode to deserialize Ratis transaction only once. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #5752:
URL: https://github.com/apache/ozone/pull/5752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org