You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by tmancill <gi...@git.apache.org> on 2016/10/17 04:18:59 UTC
[GitHub] zookeeper pull request #87: correct a few spelling typos
GitHub user tmancill opened a pull request:
https://github.com/apache/zookeeper/pull/87
correct a few spelling typos
Hi - this PR contains corrections for some spelling typos. Most of them appear in comments, but a few appear in documentation and program output. Thank you for considering it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tmancill/zookeeper tmancill/spelling-typos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit dbf2f344975d3efe67b034ccd4055acd92a06da7
Author: tony mancill <tm...@debian.org>
Date: 2016-10-17T04:14:00Z
correct a few spelling typos
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #87: ZOOKEEPER-2617: correct a few spelling typos
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/87
I'm merging this to branch-3.4.
Could you provide another PR for master/branch3.5 as this has minor conflicts and not applying properly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #87: ZOOKEEPER-2617: correct a few spelling typos
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/87
@eribeiro sure, I will consider this to 3.4.10. Thanks @tmancill for the contribution. Sorry for the delay in looking at this jira, could you please create separate PR for {{master}} branch as the current PR_87 is not applying to {{branch-3.5}} and {{master}}.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #87: ZOOKEEPER-2617: correct a few spelling typos
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/87
Hi @rakeshadr, this is another possible candidate for 3.4.10 release, in my humble opinion. Fl�vio gave his blessing and the branch doesn't conflict with branch-3.4.
PS: I didn't cherry-pick this into branch-3.5 and master so I don't know if it has any conflicts with those branches, but it would be nice to have it ported to them too.
Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #87: ZOOKEEPER-2617: correct a few spelling typos
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #87: ZOOKEEPER-2617: correct a few spelling typos
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/87
Please close this PR as this is merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #87: ZOOKEEPER-2617: correct a few spelling typos
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/87
Hi @fpj, could we have this PR merged? :)
Thanks!
PS: It is target at branch-3.4, but would be cool if we could also apply it to branch-3.5 and master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---