You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/07 23:04:29 UTC
[GitHub] [tvm] driazati opened a new pull request, #10934: [ci][build] Use ninja instead of Makefiles
driazati opened a new pull request, #10934:
URL: https://github.com/apache/tvm/pull/10934
This switches the CI build to use Ninja which has slightly nicer output and faster behavior in the face of re-runs. This also adds a `--verbose` flag to `ci.py` to control build output accordingly.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #10934: [ci][build] Use ninja instead of Makefiles
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #10934:
URL: https://github.com/apache/tvm/pull/10934#discussion_r858929674
##########
tests/scripts/ci.py:
##########
@@ -189,10 +189,9 @@ def docker(name: str, image: str, scripts: List[str], env: Dict[str, str], inter
docker_bash = REPO_ROOT / "docker" / "bash.sh"
- command = [docker_bash, "--name", name]
+ command = [docker_bash, "-t", "--name", name]
Review Comment:
would this poison Jenkins logs with lots of `[2m` or whatever?
##########
tests/scripts/task_cpp_unittest.sh:
##########
@@ -40,10 +39,20 @@ if grep crttest build/Makefile > /dev/null; then
make crttest # NOTE: don't parallelize, due to issue with build deps.
fi
-cd build && ctest --gtest_death_test_style=threadsafe && cd ..
+if grep crttest build/build.ninja > /dev/null; then
Review Comment:
i think it would be better to configure expectations here from e.g. CI_RUN_CRTTEST or a command-line arg to this script, otherwise we could silently fail if someone removes crttest as a target
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #10934: [ci][build] Use ninja instead of Makefiles
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #10934:
URL: https://github.com/apache/tvm/pull/10934#issuecomment-1125417164
thanks @driazati !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #10934: [ci][build] Use ninja instead of Makefiles
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10934:
URL: https://github.com/apache/tvm/pull/10934#issuecomment-1118010229
It has been a while since this PR was updated, @areusch please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please [convert it to a draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft) until it is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #10934: [ci][build] Use ninja instead of Makefiles
Posted by GitBox <gi...@apache.org>.
areusch merged PR #10934:
URL: https://github.com/apache/tvm/pull/10934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #10934: [ci][build] Use ninja instead of Makefiles
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #10934:
URL: https://github.com/apache/tvm/pull/10934#discussion_r860276921
##########
tests/scripts/ci.py:
##########
@@ -189,10 +189,9 @@ def docker(name: str, image: str, scripts: List[str], env: Dict[str, str], inter
docker_bash = REPO_ROOT / "docker" / "bash.sh"
- command = [docker_bash, "--name", name]
+ command = [docker_bash, "-t", "--name", name]
Review Comment:
this is only used interactively right now so it's not a big deal though, but we can check for `sys.stdout.isatty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org