You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 15:28:08 UTC
[GitHub] [beam] damccorm opened a new issue, #20109: SortValues should fail if SecondaryKey coder is not deterministic
damccorm opened a new issue, #20109:
URL: https://github.com/apache/beam/issues/20109
`SortValues` transform uses lexicographical sorting on encoded binaries and might not work correctly if the coder is not deterministic.
Imported from Jira [BEAM-8985](https://issues.apache.org/jira/browse/BEAM-8985). Original Jira may contain additional context.
Reported by: sinisa_lyh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #20109: SortValues should fail if SecondaryKey coder is not deterministic
Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #20109:
URL: https://github.com/apache/beam/issues/20109#issuecomment-1246021749
@reuvenlax FYI since I know you work with sortvalues a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #20109: SortValues should fail if SecondaryKey coder is not deterministic
Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #20109:
URL: https://github.com/apache/beam/issues/20109#issuecomment-1271931253
Ha. Good point. Independently, both statements are true:
- It is pretty straightforward to go in to the transform and add the check.
- It is a data loss risk if the coder is nondeterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on issue #20109: SortValues should fail if SecondaryKey coder is not deterministic
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on issue #20109:
URL: https://github.com/apache/beam/issues/20109#issuecomment-1270491279
Is this actually a P1 _and_ a good first issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles closed issue #20109: SortValues should fail if SecondaryKey coder is not deterministic
Posted by GitBox <gi...@apache.org>.
kennknowles closed issue #20109: SortValues should fail if SecondaryKey coder is not deterministic
URL: https://github.com/apache/beam/issues/20109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org