You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/07 04:39:00 UTC
[GitHub] [druid] gianm opened a new pull request, #13036: MSQ extension: Fix over-capacity write in ScanQueryFrameProcessor.
gianm opened a new pull request, #13036:
URL: https://github.com/apache/druid/pull/13036
Frame processors are meant to write only one output frame per cycle. The ScanQueryFrameProcessor would write two when reading from a channel if the input frame cursor cycled and then the output frame filled up while reading from the next frame.
This patch fixes the bug, and adds a test. It also makes some adjustments to the processor code in order to make it easier to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #13036: MSQ extension: Fix over-capacity write in ScanQueryFrameProcessor.
Posted by GitBox <gi...@apache.org>.
gianm commented on PR #13036:
URL: https://github.com/apache/druid/pull/13036#issuecomment-1238968108
> It would be cool to understand how you debugged this also.
I ran into an error "Channel has no capacity" from BlockingQueueFrameChannel in a test cluster. The stack trace indicated it was a frame write from ScanQueryFrameProcessor `populateFrameWriterAndFlushIfNeeded`. Knowing that this error means that a processor wrote two frames in a single cycle, I read through the code and thought about ways that this might happen. I found this one, and wrote a test case & fix for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13036: MSQ extension: Fix over-capacity write in ScanQueryFrameProcessor.
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged PR #13036:
URL: https://github.com/apache/druid/pull/13036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #13036: MSQ extension: Fix over-capacity write in ScanQueryFrameProcessor.
Posted by GitBox <gi...@apache.org>.
gianm commented on PR #13036:
URL: https://github.com/apache/druid/pull/13036#issuecomment-1238901620
This part is the fix: https://github.com/apache/druid/pull/13036/files#diff-9b472caafa614f6c7b93fc27e09e8192b1bd6b665857ed0e5946f73035ac633cL206-R207
The rest is refactoring to make it possible to write the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org