You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/07/27 12:16:53 UTC
[GitHub] [incubator-uniffle] xianjingfeng opened a new pull request, #93: [Feature Request] Support shuffle server decommissioned
xianjingfeng opened a new pull request, #93:
URL: https://github.com/apache/incubator-uniffle/pull/93
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. Create a new rpc api for decommissioned in shuffle server, we can request this api by shell.
2. When shuffle server is in decommissioned state, it will exit where all applications finished and it will report to coodirator by heartbeat.
3. Coodirator will exclude decommissioned node when assign partition.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
5. If you fix a bug, you can clarify why it is a bug.
-->
kill process is not graceful, so we need shuffle server support decommissioned
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
tests were added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #93: [Feature Request] Support shuffle server decommissioned
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on PR #93:
URL: https://github.com/apache/incubator-uniffle/pull/93#issuecomment-1196959313
1.Exclude is not equals to decommission, we can refer to **HDFS**
2.Coordinator should be stateless, if not, we need ensure multi instance data synchronization
3.I don't think store **exclude-node-file** in hdfs and update periodically is a good choice.
4.Whether or not controlled by coordinator，shuffle server need to expose an api to espond to this event. we can support controll by coordinator base on this pr
5.Maybe we can support this function first. I think without this function, users not very willing run uniffle in the production environment. Rome wasn't built in a day, uniffle has many shortcomings now
6.I hope you have better idea and implement it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #93: [Feature Request] Support shuffle server decommissioned
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #93:
URL: https://github.com/apache/incubator-uniffle/pull/93#issuecomment-1197086564
> 1.Exclude is not equals to decommission, we can refer to **HDFS** 2.Coordinator should be stateless, if not, we need ensure multi instance data synchronization 3.I don't think store **exclude-node-file** in hdfs and update periodically is a good choice. 4.Whether or not controlled by coordinator，shuffle server need to expose an api to respond to this event. we can support controll by coordinator base on this pr 5.Maybe we can support this function first. I think without this function, users not very willing run uniffle in the production environment. Rome wasn't built in a day, uniffle has many shortcomings now 6.I hope you have better idea and implement it
1. Although node exclusion is not equals to node decommission, the two operation have some similar mechanism, I think we should maintain one mechanism.
2. Agree with you, should we add a extra service for standalone mode deployment?
3. Agree with you, better solution is to have configuration abstraction.
4. Maybe some people think we can reuse the heartbeat to control the shuffle server, it depends our concrete implement.
5. We should have design document , discuss about more details, do more survery about other system. We need this function, but this implement may not be the best solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng closed pull request #93: feat: support shuffle server decommissioned
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng closed pull request #93: feat: support shuffle server decommissioned
URL: https://github.com/apache/incubator-uniffle/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #93: [Feature Request] Support shuffle server decommissioned
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #93:
URL: https://github.com/apache/incubator-uniffle/pull/93#issuecomment-1196664046
I'm confused why not reuse the exclude-node-file? And the decommission operation maybe controlled by coordinator will be better?
Do u have any ideas on it? @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #93: [Feature Request] Support shuffle server decommissioned
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #93:
URL: https://github.com/apache/incubator-uniffle/pull/93#issuecomment-1196873837
> I'm confused why not reuse the exclude-node-file? And the decommission operation maybe controlled by coordinator will be better?
>
> Do u have any ideas on it? @jerqi
Agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org